You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/05/06 21:05:46 UTC
[GitHub] [incubator-mxnet] TristonC opened a new pull request, #21018: [BUGFIX] Fix nms kernel's out of range access error
TristonC opened a new pull request, #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018
## Description ##
This fix the error found in a object detection case with following error
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Remove the element_width limitation of 20 in CalculateGreedyNMSResultsKernel
## Comments ##
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access error
Posted by GitBox <gi...@apache.org>.
TristonC commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1120011749
@ptrendx @josephevans
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access error
Posted by GitBox <gi...@apache.org>.
TristonC commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1120008868
PRed into the wrong branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access issue
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1124306292
Jenkins CI successfully triggered : [unix-cpu, windows-gpu, centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access issue
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1126295391
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access issue
Posted by GitBox <gi...@apache.org>.
TristonC commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1126295315
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access issue
Posted by GitBox <gi...@apache.org>.
TristonC commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1124306204
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC closed pull request #21018: [BUGFIX] Fix nms kernel's out of range access error
Posted by GitBox <gi...@apache.org>.
TristonC closed pull request #21018: [BUGFIX] Fix nms kernel's out of range access error
URL: https://github.com/apache/incubator-mxnet/pull/21018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx merged pull request #21018: [BUGFIX] Fix nms kernel's out of range access issue
Posted by GitBox <gi...@apache.org>.
ptrendx merged PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access issue
Posted by GitBox <gi...@apache.org>.
ptrendx commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1125289676
This is a legitimate failure - we are using C++17 which does not need message in static_assert, but the previous versions do (and 1.x uses older C++ standard) - you need to add the message to static_assert. This is the error message:
```
error: expected a comma (the one-argument version of static_assert is not enabled in this mode)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21018: [BUGFIX] Fix nms kernel's out of range access error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21018:
URL: https://github.com/apache/incubator-mxnet/pull/21018#issuecomment-1120007471
Hey @TristonC , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, unix-gpu, centos-cpu, windows-gpu, centos-gpu, clang, unix-cpu, sanity, edge, website, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org