[GitHub] [pulsar] codelipenghui opened a new pull request #5339: Not allow use acknowledgeCumulative on Key_shared subscription.

[GitBox <gi...@apache.org>]

codelipenghui opened a new pull request #5339: Not allow use acknowledgeCumulative on Key_shared subscription.
URL: https://github.com/apache/pulsar/pull/5339
 
 
   ### Motivation
   
   Key_Shared subscription is a enhancement of shared subscription, we should avoid use acknowledgeCumulative on Key_shared subscription
   
   ### Modifications
   
   Add allow acknowledgeCumulative check for Key_shared subscription
   
   ### Verifying this change
   
   Add new unit test.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: ( no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services