You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "RyanSkraba (via GitHub)" <gi...@apache.org> on 2024/04/09 10:07:18 UTC
[PR] [FLINK-35023][tests] Use surefire.module.config in yarn-test [flink]
RyanSkraba opened a new pull request, #24641:
URL: https://github.com/apache/flink/pull/24641
## What is the purpose of the change
For JDK 17+, some configuration is necessary to use the Datastream V2 (FLINK-34548 and FLIP-409). This was added to `surefire.module.config` for most of the necessary tests. The `flink-yarn-tests` spawn new processes (notably JobManager) which should take into account the same configuration as other surefire tests.
## Brief change log
* Copy the `surefire.module.config` property into the `env.java.opts.all` Flink configuration when running a new test cluster.
## Verifying this change
This change fixes an existing test: `YARNApplicationITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35023][tests] Use surefire.module.config in yarn-test [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24641:
URL: https://github.com/apache/flink/pull/24641#issuecomment-2044638650
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d747f820b8f168151b84ca7ed2a7d3b4f8413fa6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d747f820b8f168151b84ca7ed2a7d3b4f8413fa6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d747f820b8f168151b84ca7ed2a7d3b4f8413fa6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35023][tests] Use surefire.module.config in yarn-test [flink]
Posted by "RyanSkraba (via GitHub)" <gi...@apache.org>.
RyanSkraba commented on PR #24641:
URL: https://github.com/apache/flink/pull/24641#issuecomment-2045111969
> Thanks for the contribution @RyanSkraba
>
> I would suggest to move the change under `createDefaultConfiguration` method to have setting up of the configuration in one place
>
> WDYT?
Perfect, done (and push --forced). I've run this on [my own CI](https://github.com/RyanSkraba/flink/actions/runs/8614110304/job/23607771066) and the `Test (module: misc)` job passes for JDK17 and 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35023][tests] Use surefire.module.config in yarn-test [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #24641:
URL: https://github.com/apache/flink/pull/24641#issuecomment-2046728851
I also double checked locally that before the fix test fails on jdk17 and passes after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35023][tests] Use surefire.module.config in yarn-test [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #24641:
URL: https://github.com/apache/flink/pull/24641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org