You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/08 21:12:31 UTC

[GitHub] [geode] karensmolermiller commented on a change in pull request #6098: GEODE-9001: Update Documents to be match recent code changes in compatible-with-redis commands

karensmolermiller commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589749861



##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -41,6 +41,8 @@ start server \
   --redis-password=<redisPassword>
 ```
 
+Note: if any of redis-bind-address, redis-password, or redis-port are included, a compatible-with-Redis geode server will be started

Review comment:
       Please revise this sentence with some formatting and capitalization changes. I suggest:
   
   If any of the options `redis-bind-address`, `redis-password`, or `redis-port` are included, a compatible-with-Redis Geode server will be started.

##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -68,26 +70,24 @@ The Redis API for <%=vars.product_name%> currently supports the following comman
 **Note**: These commands are supported for Redis 5.
 
 -   **Connection**: AUTH, PING, QUIT
--   **Hashes**: HGETALL, HMGET, HMSET, HSET, HSETNX, HSTRLEN, HLEN, HVALS
+-   **Hashes**:HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS

Review comment:
       Add a space after the colon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org