[GitHub] [accumulo] keith-turner commented on issue #1586: Fix Accumulo hanging when TLS enabled on ZooKeeper

[GitBox <gi...@apache.org>]

keith-turner commented on issue #1586: Fix Accumulo hanging when TLS enabled on ZooKeeper
URL: https://github.com/apache/accumulo/pull/1586#issuecomment-613601627
 
 
   > I feel like the three affected tools could simply have avoided using ZooReaderWriter and ZooSession and instead just used ZooKeeper directly. 
   
   This may lead to a lot of duplication and/or require a large refactoring of code to reuse things like the authentication code for ZK.   Not sure.
   
   Another way to make this change cleaner would be to call `SingletonManager.setMode(CLOSED)` in `ServerContext.close()`.  However doing this may destabilize existing code using ServerContext.  To avoid the destabilization, could create an AdminUtilContext that extends ServerContext AND calls `SingletonManager.setMode(CLOSED)` in its close method.   Then admin util like the ones changed in this PR could do something like the following.
   
   ```java
   try(AdminUtilContext ctx = new AdminUtilContext()) {
      // do admin stuff
   }
   ```
   
   Just sharing my thoughts, not suggesting we do any of this at this point. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services