You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2023/08/14 17:24:10 UTC
[GitHub] [arrow-nanoarrow] WillAyd opened a new pull request, #274: ci: Add codespell to pre-commit
WillAyd opened a new pull request, #274:
URL: https://github.com/apache/arrow-nanoarrow/pull/274
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #274: ci: Add codespell to pre-commit
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #274:
URL: https://github.com/apache/arrow-nanoarrow/pull/274#discussion_r1294703298
##########
.pre-commit-config.yaml:
##########
@@ -57,5 +57,16 @@ repos:
- id: isort
types_or: [python]
exclude: "__init__.py$"
+ - repo: https://github.com/codespell-project/codespell
+ rev: v2.2.5
+ hooks:
+ - id: codespell
+ types_or: [rst, markdown, c, c++]
+ additional_dependencies: [tomli]
+ exclude: |
+ (?x)
+ ^extensions/nanoarrow_ipc/thirdparty
+ |nanoarrow_ipc_flatcc_generated.h
+ |nanoarrow_device_metal.cc
Review Comment:
That's perfect...I'm planning to do some work in the device extension later on and will deal with it then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #274: ci: Add codespell to pre-commit
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #274:
URL: https://github.com/apache/arrow-nanoarrow/pull/274#issuecomment-1678114877
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#274](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (90ea9e1) into [main](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/3157182596f845ef231977e8ed32b9372a7ef5e8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3157182) will **not change** coverage.
> Report is 1 commits behind head on main.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 87.19% 87.19%
=======================================
Files 66 66
Lines 10128 10128
=======================================
Hits 8831 8831
Misses 1297 1297
```
| [Files Changed](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...nanoarrow\_ipc/src/nanoarrow/nanoarrow\_ipc\_reader.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZW5zaW9ucy9uYW5vYXJyb3dfaXBjL3NyYy9uYW5vYXJyb3cvbmFub2Fycm93X2lwY19yZWFkZXIuYw==) | `92.74% <ø> (ø)` | |
| [r/src/array.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvYXJyYXkuaA==) | `86.48% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] WillAyd commented on a diff in pull request #274: ci: Add codespell to pre-commit
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #274:
URL: https://github.com/apache/arrow-nanoarrow/pull/274#discussion_r1293993158
##########
.pre-commit-config.yaml:
##########
@@ -57,5 +57,14 @@ repos:
- id: isort
types_or: [python]
exclude: "__init__.py$"
+ - repo: https://github.com/codespell-project/codespell
+ rev: v2.2.5
+ hooks:
+ - id: codespell
+ types_or: [rst, markdown, c, c++]
+ additional_dependencies: [tomli]
+ exclude: |
+ "^extensions/nanoarrow_ipc/thirdparty"
+ "|extensions/nanoarrow_ipc/src/nanoarrow/nanoarrow_ipc_flatcc_generated.h"
Review Comment:
Not sure what generates this file but assume it is OK to ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #274: ci: Add codespell to pre-commit
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #274:
URL: https://github.com/apache/arrow-nanoarrow/pull/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] WillAyd commented on a diff in pull request #274: ci: Add codespell to pre-commit
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #274:
URL: https://github.com/apache/arrow-nanoarrow/pull/274#discussion_r1294016990
##########
.pre-commit-config.yaml:
##########
@@ -57,5 +57,16 @@ repos:
- id: isort
types_or: [python]
exclude: "__init__.py$"
+ - repo: https://github.com/codespell-project/codespell
+ rev: v2.2.5
+ hooks:
+ - id: codespell
+ types_or: [rst, markdown, c, c++]
+ additional_dependencies: [tomli]
+ exclude: |
+ (?x)
+ ^extensions/nanoarrow_ipc/thirdparty
+ |nanoarrow_ipc_flatcc_generated.h
+ |nanoarrow_device_metal.cc
Review Comment:
Unfortunate as only the `pEvent` code in one of the comments is producing a false positive. We could alternately create a `.codespellignorelines` file to the repo. but figured this is fine for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] WillAyd commented on a diff in pull request #274: ci: Add codespell to pre-commit
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #274:
URL: https://github.com/apache/arrow-nanoarrow/pull/274#discussion_r1294016990
##########
.pre-commit-config.yaml:
##########
@@ -57,5 +57,16 @@ repos:
- id: isort
types_or: [python]
exclude: "__init__.py$"
+ - repo: https://github.com/codespell-project/codespell
+ rev: v2.2.5
+ hooks:
+ - id: codespell
+ types_or: [rst, markdown, c, c++]
+ additional_dependencies: [tomli]
+ exclude: |
+ (?x)
+ ^extensions/nanoarrow_ipc/thirdparty
+ |nanoarrow_ipc_flatcc_generated.h
+ |nanoarrow_device_metal.cc
Review Comment:
Unfortunate we have to exclude nanoarrow_device_metal.cc as only the `pEvent` code in one of the comments is producing a false positive. We could alternately create a `.codespellignorelines` file to the repo (or change the comment). but figured this is fine for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org