You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2023/11/21 03:40:44 UTC

[PR] [pipelineX](bug) Fix potential memory access problem [doris]

Gabriel39 opened a new pull request, #27326:
URL: https://github.com/apache/doris/pull/27326

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #27326:
URL: https://github.com/apache/doris/pull/27326#issuecomment-1820165449

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27326:
URL: https://github.com/apache/doris/pull/27326#issuecomment-1820214831

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit d748c22bbe262ccb9596cfcdee8b41310e8c61c2, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4914	4620	4646	4620
   q2	358	173	159	159
   q3	2040	1948	1918	1918
   q4	1381	1254	1253	1253
   q5	3956	3978	4042	3978
   q6	253	126	127	126
   q7	1396	883	910	883
   q8	2774	2807	2775	2775
   q9	9819	9666	9505	9505
   q10	3473	3562	3545	3545
   q11	374	244	244	244
   q12	445	290	302	290
   q13	4598	3784	3813	3784
   q14	315	283	287	283
   q15	585	538	520	520
   q16	653	582	578	578
   q17	1144	996	926	926
   q18	7751	7420	7478	7420
   q19	1686	1689	1685	1685
   q20	531	313	296	296
   q21	4385	3993	3983	3983
   q22	469	369	375	369
   Total cold run time: 53300 ms
   Total hot run time: 49140 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4595	4562	4573	4562
   q2	348	235	252	235
   q3	4008	3988	3985	3985
   q4	2699	2709	2678	2678
   q5	9708	9729	9693	9693
   q6	240	127	122	122
   q7	2999	2460	2427	2427
   q8	4454	4472	4493	4472
   q9	13245	13141	13214	13141
   q10	4097	4203	4188	4188
   q11	726	647	677	647
   q12	988	823	823	823
   q13	4305	3581	3567	3567
   q14	374	350	342	342
   q15	567	519	522	519
   q16	736	658	672	658
   q17	3778	3899	3865	3865
   q18	9477	9104	8877	8877
   q19	1831	1807	1776	1776
   q20	2389	2054	2047	2047
   q21	8785	8671	8499	8499
   q22	882	812	768	768
   Total cold run time: 81231 ms
   Total hot run time: 77891 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27326:
URL: https://github.com/apache/doris/pull/27326#issuecomment-1820314431

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27326:
URL: https://github.com/apache/doris/pull/27326#issuecomment-1820220147

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.59 seconds
    stream load tsv:          564 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.6 seconds inserted 10000000 Rows, about 349K ops/s
    storage size: 17100097550 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27326:
URL: https://github.com/apache/doris/pull/27326#issuecomment-1820314463

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #27326:
URL: https://github.com/apache/doris/pull/27326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27326:
URL: https://github.com/apache/doris/pull/27326#issuecomment-1820171095

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](bug) Fix potential memory access problem [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27326:
URL: https://github.com/apache/doris/pull/27326#issuecomment-1820246857

   TeamCity be ut coverage result:
    Function Coverage: 36.53% (8447/23122) 
    Line Coverage: 28.86% (68663/237899)
    Region Coverage: 27.83% (35514/127613)
    Branch Coverage: 24.58% (18105/73670)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/d748c22bbe262ccb9596cfcdee8b41310e8c61c2_d748c22bbe262ccb9596cfcdee8b41310e8c61c2/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org