You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/12 11:32:39 UTC
[GitHub] [skywalking] xu1009 opened a new pull request #8418: support zgc
xu1009 opened a new pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<8411>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on pull request #8418: Support ZGC
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1011719252
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8418: Support ZGC
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1011595922
I have updated the submodule, please resolve the conflicts, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on a change in pull request #8418: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#discussion_r782996477
##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/jvm/JVMSourceDispatcher.java
##########
@@ -106,6 +106,8 @@ private void sendToGCMetricProcess(String service,
break;
case OLD:
serviceInstanceJVMGC.setPhrase(GCPhrase.OLD);
Review comment:
ok,fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on pull request #8418: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1010957224
> I think you submitted this PR too early? Protocol PR has been merged, so you don't have correct submodule.
ok, the proto pr https://github.com/apache/skywalking-data-collect-protocol/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 closed pull request #8418: Support ZGC
Posted by GitBox <gi...@apache.org>.
xu1009 closed pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on pull request #8418: Support ZGC
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1012029340
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8418: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1010949730
I think you submitted this PR too early? Protocol PR has been merged, so you don't have correct submodule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8418: Support ZGC
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1011857827
Please fix the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on pull request #8418: Support ZGC
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1011907702
the failed ci check seems no relation with this commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8418: Support ZGC
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#issuecomment-1011972531
The error is strange. Could you try to close this PR and open another one? I feel this is CI env issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8418: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8418:
URL: https://github.com/apache/skywalking/pull/8418#discussion_r782991405
##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/jvm/JVMSourceDispatcher.java
##########
@@ -106,6 +106,8 @@ private void sendToGCMetricProcess(String service,
break;
case OLD:
serviceInstanceJVMGC.setPhrase(GCPhrase.OLD);
Review comment:
Miss break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org