You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Dave Cramer <da...@gmail.com> on 2012/04/11 15:47:21 UTC
groovy ldap
Hi
I've found a bug
Index: src/main/java/org/apache/directory/groovyldap/LDAP.java
===================================================================
--- src/main/java/org/apache/directory/groovyldap/LDAP.java
(revision 1324703)
+++ src/main/java/org/apache/directory/groovyldap/LDAP.java (working copy)
@@ -607,7 +607,8 @@
}
finally
{
- ctx.close();
+ if (ctx != null )
+ ctx.close();
}
return result;
}
Is this under active development ?
Dave
Re: groovy ldap
Posted by Stefan Zoerner <st...@labeo.de>.
Hi Dave!
Thnks for the report. I have fixed it in svn. The development is not
that vivid.
From my point of view, it is still a proove of concept.
Greetings from Hamburg,
StefanZ
Am 11.04.2012 15:47, schrieb Dave Cramer:
> Hi
>
> I've found a bug
>
>
> Index: src/main/java/org/apache/directory/groovyldap/LDAP.java
> ===================================================================
> --- src/main/java/org/apache/directory/groovyldap/LDAP.java
> (revision 1324703)
> +++ src/main/java/org/apache/directory/groovyldap/LDAP.java (working copy)
> @@ -607,7 +607,8 @@
> }
> finally
> {
> - ctx.close();
> + if (ctx != null )
> + ctx.close();
> }
> return result;
> }
>
>
> Is this under active development ?
>
> Dave
>
Re: groovy ldap
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 4/11/12 6:18 PM, Stefan Zoerner a écrit :
> I have overseen you mail.
> Patch already fixed. Project still builds.
Good to know !!! Pretty solid if it stills compile after all those years :)
I wish we can use the LDAP API under the hood instead of JNDI...
Thanks Stefan !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: groovy ldap
Posted by Stefan Zoerner <st...@labeo.de>.
I have overseen you mail.
Patch already fixed. Project still builds.
Am 11.04.2012 16:26, schrieb Emmanuel Lécharny:
> Le 4/11/12 3:47 PM, Dave Cramer a écrit :
>> Hi
>>
>> I've found a bug
>>
>>
>> Index: src/main/java/org/apache/directory/groovyldap/LDAP.java
>> ===================================================================
>> --- src/main/java/org/apache/directory/groovyldap/LDAP.java
>> (revision 1324703)
>> +++ src/main/java/org/apache/directory/groovyldap/LDAP.java
>> (working copy)
>> @@ -607,7 +607,8 @@
>> }
>> finally
>> {
>> - ctx.close();
>> + if (ctx != null )
>> + ctx.close();
>> }
>> return result;
>> }
>>
>>
>> Is this under active development ?
>
> Active, no, but we can wake up the project :)
>
> The best would be to create JIRAs with founs bugs.
>
> (I will apply this one and see if the project still compiles).
>
>
Re: groovy ldap
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 4/11/12 3:47 PM, Dave Cramer a écrit :
> Hi
>
> I've found a bug
>
>
> Index: src/main/java/org/apache/directory/groovyldap/LDAP.java
> ===================================================================
> --- src/main/java/org/apache/directory/groovyldap/LDAP.java
> (revision 1324703)
> +++ src/main/java/org/apache/directory/groovyldap/LDAP.java (working copy)
> @@ -607,7 +607,8 @@
> }
> finally
> {
> - ctx.close();
> + if (ctx != null )
> + ctx.close();
> }
> return result;
> }
>
>
> Is this under active development ?
Active, no, but we can wake up the project :)
The best would be to create JIRAs with founs bugs.
(I will apply this one and see if the project still compiles).
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com