You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/12 20:45:42 UTC
[GitHub] [apisix-dashboard] anldrms opened a new pull request, #2452: Turkish Language support added
anldrms opened a new pull request, #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452
This is the initial pull request for adding Turkish language offical support for Apisix Dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] anldrms commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
anldrms commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1127255085
> I see that some of the content is not translated completely, which may cause some problems, for example: <img alt="image" width="1477" src="https://user-images.githubusercontent.com/30611190/168505559-4b11d054-a57e-4448-a0ad-c83dc5c53fa6.png">
Thanks for the feedback , i'll check it later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1125576909
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2452?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2452](https://codecov.io/gh/apache/apisix-dashboard/pull/2452?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47123bb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/92f46d9d2fa8438659131eedecf9cab4c87b0f9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92f46d9) will **decrease** coverage by `1.49%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
- Coverage 70.27% 68.77% -1.50%
==========================================
Files 189 131 -58
Lines 7492 3456 -4036
Branches 845 845
==========================================
- Hits 5265 2377 -2888
+ Misses 1922 1079 -843
+ Partials 305 0 -305
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `68.77% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
| [api/cmd/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC92ZXJzaW9uLmdv) | | |
| [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | | |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | |
| [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | |
| [...pi/internal/handler/system\_config/system\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3lzdGVtX2NvbmZpZy9zeXN0ZW1fY29uZmlnLmdv) | | |
| ... and [49 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2452/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2452?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2452?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [92f46d9...47123bb](https://codecov.io/gh/apache/apisix-dashboard/pull/2452?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] anldrms commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
anldrms commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1128613466
Could you check again :) I am apologies for trouble
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2452: feat: support Turkish Language
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1129482510
Nice job 👍 @anldrms, after verifying that it works, we may need to spend some time checking the accuracy of the translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] anldrms commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
anldrms commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1134553052
> LGTM
Thanks for the review. Is there anything to fix that on my side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] anldrms commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
anldrms commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1127269944
@Baoyuantop could you point it the location of missing ones? Cause i checked it but didnt find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1135322339
> > LGTM
>
> Thanks for the review. Is there anything to fix that on my side?
You can follow the hints in the screenshot above to make the fix, which is a spelling error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1127127375
I see that some of the content is not translated completely, which may cause some problems, for example:
<img width="1477" alt="image" src="https://user-images.githubusercontent.com/30611190/168505559-4b11d054-a57e-4448-a0ad-c83dc5c53fa6.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1128453559
> @Baoyuantop could you point it the location of missing ones? Cause i checked it but didnt find.
They are under `web/src/pages`; for example, there is a locales folder under Route in this directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] anldrms commented on pull request #2452: Turkish Language support added
Posted by GitBox <gi...@apache.org>.
anldrms commented on PR #2452:
URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1135452181
Now its ok i guess there is no parallel in Turkish so i deleted from the sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org