You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/09/20 03:06:05 UTC

Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71518/
-----------------------------------------------------------

(Updated Sept. 20, 2019, 11:06 a.m.)


Review request for mesos and Gilbert Song.


Changes
-------

Made this test linux specific.


Summary (updated)
-----------------

Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.


Bugs: MESOS-9966
    https://issues.apache.org/jira/browse/MESOS-9966


Repository: mesos


Description (updated)
-------

Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.


Diffs (updated)
-----

  src/tests/gc_tests.cpp 2ea4bcb668e1fcbeb9c598053e4df4d54d17711d 


Diff: https://reviews.apache.org/r/71518/diff/2/

Changes: https://reviews.apache.org/r/71518/diff/1-2/


Testing
-------

sudo make check

This test will fail without the previous patch r/71501.


Thanks,

Qian Zhang


Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71518/#review217971
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Sept. 19, 2019, 8:06 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71518/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2019, 8:06 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9966
>     https://issues.apache.org/jira/browse/MESOS-9966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.
> 
> 
> Diffs
> -----
> 
>   src/tests/gc_tests.cpp 2ea4bcb668e1fcbeb9c598053e4df4d54d17711d 
> 
> 
> Diff: https://reviews.apache.org/r/71518/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> This test will fail without the previous patch r/71501.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71518/#review217876
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71501, 71518]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 20, 2019, 3:06 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71518/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2019, 3:06 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9966
>     https://issues.apache.org/jira/browse/MESOS-9966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.
> 
> 
> Diffs
> -----
> 
>   src/tests/gc_tests.cpp 2ea4bcb668e1fcbeb9c598053e4df4d54d17711d 
> 
> 
> Diff: https://reviews.apache.org/r/71518/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> This test will fail without the previous patch r/71501.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>