You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/12/17 19:55:44 UTC
[jira] Created: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
cleanup the logging levels used (use the correct level) and messages generated
------------------------------------------------------------------------------
Key: ZOOKEEPER-259
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
Project: Zookeeper
Issue Type: Improvement
Components: c client, java client, server
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Minor
Fix For: 3.1.0
Cleanup logging:
make sure logging uses the correct level, esp error and warn
make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-259:
-----------------------------------
Attachment: ZOOKEEPER-259.patch
This patch generally cleans up logging
1) better log level - esp wrt fatal/error/warn being used appropriately
2) better message text (esp where msg was fixmsg)
Additionally I've also:
1) in both the c and java clients I added logging of ping latency (DEBUG)
2) cleaned up the trace logging in a few places (some trace that should have
been INFO or DEBUG)
3) sendbuffer in nioservercnxn - removed what looked like unnecessary wrap
Be sure to review this during patch review
4) in syncrequestprocessor changed the run method to catch throwable
rather than exception. errors could have slipped through
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-259:
-----------------------------------
Status: Patch Available (was: Open)
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-259:
-----------------------------------
Status: Open (was: Patch Available)
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-259:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 734857.
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch, ZOOKEEPER-259.patch, ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-259:
-----------------------------------
Status: Patch Available (was: Open)
Please review this for inclusion, in particular verify that the logging level selected is correct.
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch, ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-259:
------------------------------------
Attachment: ZOOKEEPER-259.patch
Fixed to work with latest code.
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch, ZOOKEEPER-259.patch, ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-259:
-----------------------------------
Attachment: ZOOKEEPER-259.patch
Updated the patch to fix an incorrect logging level (should have been trace, not debug).
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch, ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-259) cleanup the logging levels used
(use the correct level) and messages generated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664597#action_12664597 ]
Hudson commented on ZOOKEEPER-259:
----------------------------------
Integrated in ZooKeeper-trunk #198 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/198/])
> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-259.patch, ZOOKEEPER-259.patch, ZOOKEEPER-259.patch
>
>
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.