You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by ag...@apache.org on 2007/06/18 23:53:05 UTC
svn commit: r548502 -
/roller/trunk/apps/weblogger/src/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java
Author: agilliland
Date: Mon Jun 18 14:53:04 2007
New Revision: 548502
URL: http://svn.apache.org/viewvc?view=rev&rev=548502
Log:
handle IllegalArgumentExceptions coming from calls to request.getDateHeader(). we don't really want to throw these exceptions back to the webserver and have them end up as 500 responses when we can handle them ourselves.
Modified:
roller/trunk/apps/weblogger/src/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java
Modified: roller/trunk/apps/weblogger/src/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java
URL: http://svn.apache.org/viewvc/roller/trunk/apps/weblogger/src/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java?view=diff&rev=548502&r1=548501&r2=548502
==============================================================================
--- roller/trunk/apps/weblogger/src/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java (original)
+++ roller/trunk/apps/weblogger/src/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java Mon Jun 18 14:53:04 2007
@@ -50,7 +50,14 @@
public static boolean respondIfNotModified(HttpServletRequest request,
HttpServletResponse response,
long lastModifiedTimeMillis) {
- long sinceDate = request.getDateHeader("If-Modified-Since");
+ long sinceDate = 0;
+ try {
+ sinceDate = request.getDateHeader("If-Modified-Since");
+ } catch(IllegalArgumentException ex) {
+ // this indicates there was some problem parsing the header value as a date
+ return false;
+ }
+
// truncate to seconds
lastModifiedTimeMillis -= (lastModifiedTimeMillis % 1000);
log.debug("since date = " + sinceDate);