You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/30 20:40:01 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12655: [TIR][StorageRewrite] Allow in-place buffer reuse of non-flat memory
Lunderberg opened a new pull request, #12655:
URL: https://github.com/apache/tvm/pull/12655
Previously, shared buffer use was entirely disabled for non-flat memory, since the existing checks for shared memory assume flat 1-d spaces. This was enforced in `FindAlloc` and validated in `PrepareNewAlloc`. The validation in `PrepareNewAlloc` could trigger, if the buffer sharing was due to an in-place operation, and not through the `FindAlloc` function.
In-place operations do not require N-d packing, nor do they introduce ambiguity in how different code generators may interpret non-flat physical indices. Therefore, this commit relaxes the validation in `PrepareNewAlloc`, allowing buffer reuse of non-flat buffers for in-place operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12655: [TIR][StorageRewrite] Allow in-place buffer reuse of non-flat memory
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12655:
URL: https://github.com/apache/tvm/pull/12655#issuecomment-1232145019
Unit tests in this PR depend on the `T.decl_buffer` syntax introduced in PR#12412. When that PR merges, this will be rebased on top of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #12655: [TIR][StorageRewrite] Allow in-place buffer reuse of non-flat memory
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #12655:
URL: https://github.com/apache/tvm/pull/12655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12655: [TIR][StorageRewrite] Allow in-place buffer reuse of non-flat memory
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12655:
URL: https://github.com/apache/tvm/pull/12655#issuecomment-1234527358
cc @cconvey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org