Re: [PR] MINOR: Rewrite ClientOAuthIntegrationTest from Scala to Java [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #22520:
URL: https://github.com/apache/kafka/pull/22520#discussion_r3504934509


##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java:
##########
@@ -108,10 +108,16 @@ public class ClusterTestExtensions implements TestTemplateInvocationContextProvi
     private static final String ATTACH_LISTENER_THREAD_PREFIX = "Attach Listener";
     private static final String PROCESS_REAPER_THREAD_PREFIX = "process reaper";
     private static final String RMI_THREAD_PREFIX = "RMI";
+    // The following three thread prefixes are spawned by MockOAuth2Server (which uses OkHttp's MockWebServer
+    // internally) in ClientOAuthIntegrationTest.
+    private static final String MOCK_WEB_SERVER_THREAD_PREFIX = "MockWebServer";
+    private static final String KEEP_ALIVE_TIMER_THREAD_PREFIX = "Keep-Alive-Timer";
+    private static final String POOL_THREAD_PREFIX = "pool-";

Review Comment:
   >Executors.defaultThreadFactory().
   
   Could you share the code with me? It looks like a real leak?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org