You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/20 01:45:17 UTC

[GitHub] [incubator-linkis-website] Beacontownfc opened a new pull request, #362: Show doc verson in the top bar

Beacontownfc opened a new pull request, #362:
URL: https://github.com/apache/incubator-linkis-website/pull/362

   ![174507771-68ae25e7-0f43-4d9c-a2c8-9fc8c1af9190](https://user-images.githubusercontent.com/89081023/174511171-7bbd95f8-582f-4394-8d55-870634f297b3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org


[GitHub] [incubator-linkis-website] casionone commented on a diff in pull request #362: Show doc verson in the top bar

Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #362:
URL: https://github.com/apache/incubator-linkis-website/pull/362#discussion_r903419015


##########
src/pages/index.jsx:
##########
@@ -8,6 +8,12 @@ import useIsBrowser from '@docusaurus/useIsBrowser';
 export default function() {
   const isBrowser = useIsBrowser();
   const {siteConfig} = useDocusaurusContext();
+  const {globalData} = useDocusaurusContext();
+
+  globalData['docusaurus-plugin-content-docs'].default.versions[1].label = '1.1.1';
+  globalData['docusaurus-plugin-content-docs'].default.versions[1].isLast = false;
+  globalData['docusaurus-plugin-content-docs'].default.versions[0].isLast = true;
+

Review Comment:
   Each new document version needs to modify this configuration,
   Is it possible to automatically identify here.
   About shenyu-website, refer  it achieve? 
   https://github.com/apache/incubator-shenyu-website/blob/main/docusaurus.config.js 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org


[GitHub] [incubator-linkis-website] Beacontownfc commented on a diff in pull request #362: Show doc verson in the top bar

Posted by GitBox <gi...@apache.org>.
Beacontownfc commented on code in PR #362:
URL: https://github.com/apache/incubator-linkis-website/pull/362#discussion_r904404193


##########
src/pages/index.jsx:
##########
@@ -8,6 +8,12 @@ import useIsBrowser from '@docusaurus/useIsBrowser';
 export default function() {
   const isBrowser = useIsBrowser();
   const {siteConfig} = useDocusaurusContext();
+  const {globalData} = useDocusaurusContext();
+
+  globalData['docusaurus-plugin-content-docs'].default.versions[1].label = '1.1.1';
+  globalData['docusaurus-plugin-content-docs'].default.versions[1].isLast = false;
+  globalData['docusaurus-plugin-content-docs'].default.versions[0].isLast = true;
+

Review Comment:
   Configured from JSON configuration file instead. @casionone 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org


[GitHub] [incubator-linkis-website] Beacontownfc commented on pull request #362: Show doc verson in the top bar

Posted by GitBox <gi...@apache.org>.
Beacontownfc commented on PR #362:
URL: https://github.com/apache/incubator-linkis-website/pull/362#issuecomment-1161096668

   #359 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org


[GitHub] [incubator-linkis-website] casionone merged pull request #362: Show doc verson in the top bar

Posted by GitBox <gi...@apache.org>.
casionone merged PR #362:
URL: https://github.com/apache/incubator-linkis-website/pull/362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org