You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by pa...@apache.org on 2017/05/05 03:51:17 UTC
groovy git commit: GROOVY-8174: Groovy.Sql+Oracle parameter
substitution problem (closes #534)
Repository: groovy
Updated Branches:
refs/heads/master 942cf4eb3 -> 01df7b53c
GROOVY-8174: Groovy.Sql+Oracle parameter substitution problem (closes #534)
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/01df7b53
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/01df7b53
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/01df7b53
Branch: refs/heads/master
Commit: 01df7b53c2361693cb0efbcf3636b55e89b5da82
Parents: 942cf4e
Author: paulk <pa...@asert.com.au>
Authored: Thu May 4 10:53:41 2017 +1000
Committer: paulk <pa...@asert.com.au>
Committed: Fri May 5 13:49:27 2017 +1000
----------------------------------------------------------------------
subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/01df7b53/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java
----------------------------------------------------------------------
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java b/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java
index 26d52df..fd0ff13 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java
@@ -4114,8 +4114,10 @@ public class Sql {
Map paramsMap = (Map) params.get(0);
if (paramsMap.isEmpty()) return;
}
- if (metaData.getParameterCount() != params.size()) {
+ if (metaData.getParameterCount() < params.size()) {
throw new IllegalArgumentException("Found " + metaData.getParameterCount() + " parameter placeholders but supplied with " + params.size() + " parameters");
+ } else if (metaData.getParameterCount() != params.size()) {
+ LOG.warning("Found " + metaData.getParameterCount() + " parameter placeholders but supplied with " + params.size() + " parameters");
}
}
for (Object value : params) {