You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2026/02/03 18:57:29 UTC
[PR] Fix ResponseStoreCleaner bugs causing unbounded response store growth and cleanup failures [pinot]
yashmayya opened a new pull request, #17622:
URL: https://github.com/apache/pinot/pull/17622
## Summary
Fixes critical bugs in `ResponseStoreCleaner` that caused:
- Response store directories on brokers to grow unbounded (100s of GBs) until disk exhaustion
- Cleanup jobs to fail with timeout errors when response stores are large
- Cascading 404 errors during delete operations due to duplicate requests
## Problem
The `ResponseStoreCleaner` periodic task had several issues preventing effective cleanup:
1. **URL accumulation bug**: The `brokerUrls` list was declared outside the broker iteration loop but never cleared between iterations. This caused:
- Delete URLs to accumulate across all brokers
- Requests being sent to wrong brokers (e.g., trying to delete broker1's responses via broker2)
- Duplicate delete requests causing 404 errors
2. **Insufficient timeout**: The 3-second timeout was too short for brokers with large response stores, as `getAllStoredResponses()` must read and deserialize every response file.
3. **404 treated as failure**: Delete operations returning 404 were treated as errors, but for idempotent cleanup, a missing response means the goal is already achieved.
4. **Single broker failure blocked all cleanup**: An exception from any broker stopped processing of all remaining brokers.
## Changes
- **Split timeouts**: Increased GET timeout to 60s (from 3s) for listing operations; DELETE timeout set to 10s
- **Fixed URL scoping**: Moved `brokerUrls` declaration inside the broker loop so each broker's URLs are processed independently
- **Idempotent deletes**: 404 responses are now treated as success (response already deleted)
- **Partial failure tolerance**: Cleanup continues for remaining brokers even if one fails; only throws if ALL brokers fail
- **Better error isolation**: Separate try-catch blocks for auth, GET, and per-broker DELETE operations
- **Improved logging**: Added structured logging for cleanup progress and partial failures
## Test Plan
- [ ] Verify existing `CursorIntegrationTest` passes
- [ ] Manual testing with multiple brokers to verify per-broker URL isolation
- [ ] Verify 404 responses during delete are logged at DEBUG level and don't cause failures
- [ ] Test partial failure scenario (one broker down) to confirm other brokers are still cleaned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix ResponseStoreCleaner bugs causing unbounded response store growth and cleanup failures [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya merged PR #17622:
URL: https://github.com/apache/pinot/pull/17622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix ResponseStoreCleaner bugs causing unbounded response store growth and cleanup failures [pinot]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17622:
URL: https://github.com/apache/pinot/pull/17622#discussion_r2767160129
##########
pinot-controller/src/test/java/org/apache/pinot/controller/cursors/ResponseStoreCleanerTest.java:
##########
@@ -0,0 +1,332 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.controller.cursors;
+
+import com.sun.net.httpserver.HttpExchange;
+import com.sun.net.httpserver.HttpHandler;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.net.URI;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executor;
+import java.util.concurrent.Executors;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager;
+import org.apache.helix.model.InstanceConfig;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.response.broker.CursorResponseNative;
+import org.apache.pinot.controller.ControllerConf;
+import org.apache.pinot.controller.LeadControllerManager;
+import org.apache.pinot.controller.helix.core.PinotHelixResourceManager;
+import org.apache.pinot.controller.utils.FakeHttpServer;
+import org.apache.pinot.spi.metrics.PinotMetricUtils;
+import org.apache.pinot.spi.utils.JsonUtils;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+
+
+public class ResponseStoreCleanerTest {
+ private static final String RESPONSE_STORE_PATH = "/responseStore";
+ private static final long CURRENT_TIME_MS = 1000000L;
+
+ private final Executor _executor = Executors.newFixedThreadPool(4);
Review Comment:
The executor is created in a field initializer but never shut down. This can lead to resource leaks when tests complete. Consider creating it in `@BeforeClass` and properly shutting it down in `@AfterClass` alongside the broker servers and connection manager cleanup.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java:
##########
@@ -132,34 +131,110 @@ public void doClean(long currentTime) {
Integer.parseInt(HelixHelper.getGrpcPort(broker))));
}
+ Map<String, String> requestHeaders;
try {
- Map<String, String> requestHeaders = AuthProviderUtils.makeAuthHeadersMap(_authProvider);
+ requestHeaders = AuthProviderUtils.makeAuthHeadersMap(_authProvider);
+ } catch (Exception e) {
+ LOGGER.error("Failed to create auth headers for response store cleanup", e);
+ return;
+ }
- Map<String, List<CursorResponseNative>> brokerCursorsMap = getAllQueryResults(brokers, requestHeaders);
+ Map<String, List<CursorResponseNative>> brokerCursorsMap;
+ try {
+ brokerCursorsMap = getAllQueryResults(brokers, requestHeaders);
+ } catch (Exception e) {
+ LOGGER.error("Failed to get query results from brokers for cleanup", e);
+ return;
+ }
+
+ String protocol = _controllerConf.getControllerBrokerProtocol();
+ int portOverride = _controllerConf.getControllerBrokerPortOverride();
- String protocol = _controllerConf.getControllerBrokerProtocol();
- int portOverride = _controllerConf.getControllerBrokerPortOverride();
+ // Process each broker independently to ensure partial failures don't block cleanup of other brokers
+ for (Map.Entry<String, List<CursorResponseNative>> entry : brokerCursorsMap.entrySet()) {
+ String brokerKey = entry.getKey();
+ InstanceInfo broker = brokers.get(brokerKey);
+ if (broker == null) {
+ LOGGER.warn("Broker not found for key: {}", brokerKey);
+ continue;
+ }
Review Comment:
The null check for `broker` is defensive but unnecessary since `brokerCursorsMap` is built from the same `brokers` map in `getAllQueryResults()`. This condition should never be true unless there's a concurrent modification issue. Consider removing this check or adding a comment explaining why it's needed if there's a legitimate edge case.
```suggestion
```
##########
pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java:
##########
@@ -132,34 +131,110 @@ public void doClean(long currentTime) {
Integer.parseInt(HelixHelper.getGrpcPort(broker))));
}
+ Map<String, String> requestHeaders;
try {
- Map<String, String> requestHeaders = AuthProviderUtils.makeAuthHeadersMap(_authProvider);
+ requestHeaders = AuthProviderUtils.makeAuthHeadersMap(_authProvider);
+ } catch (Exception e) {
+ LOGGER.error("Failed to create auth headers for response store cleanup", e);
+ return;
+ }
- Map<String, List<CursorResponseNative>> brokerCursorsMap = getAllQueryResults(brokers, requestHeaders);
+ Map<String, List<CursorResponseNative>> brokerCursorsMap;
+ try {
+ brokerCursorsMap = getAllQueryResults(brokers, requestHeaders);
+ } catch (Exception e) {
+ LOGGER.error("Failed to get query results from brokers for cleanup", e);
+ return;
+ }
+
+ String protocol = _controllerConf.getControllerBrokerProtocol();
+ int portOverride = _controllerConf.getControllerBrokerPortOverride();
- String protocol = _controllerConf.getControllerBrokerProtocol();
- int portOverride = _controllerConf.getControllerBrokerPortOverride();
+ // Process each broker independently to ensure partial failures don't block cleanup of other brokers
+ for (Map.Entry<String, List<CursorResponseNative>> entry : brokerCursorsMap.entrySet()) {
+ String brokerKey = entry.getKey();
+ InstanceInfo broker = brokers.get(brokerKey);
+ if (broker == null) {
+ LOGGER.warn("Broker not found for key: {}", brokerKey);
+ continue;
+ }
+ // Collect URLs for expired responses for THIS broker only
List<String> brokerUrls = new ArrayList<>();
- for (Map.Entry<String, List<CursorResponseNative>> entry : brokerCursorsMap.entrySet()) {
- for (CursorResponse response : entry.getValue()) {
- if (response.getExpirationTimeMs() <= currentTime) {
- InstanceInfo broker = brokers.get(entry.getKey());
- int port = portOverride > 0 ? portOverride : broker.getPort();
- brokerUrls.add(
- String.format(DELETE_QUERY_RESULT, protocol, broker.getHost(), port, response.getRequestId()));
- }
+ for (CursorResponse response : entry.getValue()) {
+ if (response.getExpirationTimeMs() <= currentTime) {
+ int port = portOverride > 0 ? portOverride : broker.getPort();
+ brokerUrls.add(
+ String.format(DELETE_QUERY_RESULT, protocol, broker.getHost(), port, response.getRequestId()));
}
- Map<String, String> deleteStatus = getResponseMap(requestHeaders, brokerUrls, "DELETE", HttpDelete::new);
+ }
+ if (brokerUrls.isEmpty()) {
+ LOGGER.debug("No expired responses to clean up for broker: {}", brokerKey);
+ continue;
+ }
+
+ LOGGER.info("Cleaning up {} expired responses from broker: {}", brokerUrls.size(), brokerKey);
+
+ try {
+ Map<String, String> deleteStatus =
+ deleteExpiredResponses(requestHeaders, brokerUrls);
deleteStatus.forEach(
(key, value) -> LOGGER.info("ResponseStore delete response - Broker: {}. Response: {}", key, value));
+ } catch (Exception e) {
+ // Log error but continue with other brokers - don't let one broker failure block cleanup of others
+ LOGGER.error("Failed to delete expired responses from broker: {}. Will retry on next cleanup cycle.",
+ brokerKey, e);
}
- } catch (Exception e) {
- LOGGER.error(e.getMessage());
}
}
+ /**
+ * Delete expired responses from brokers. Treats 404 responses as success since the goal
+ * is to ensure the response doesn't exist (idempotent delete).
+ */
+ private Map<String, String> deleteExpiredResponses(Map<String, String> requestHeaders, List<String> brokerUrls)
+ throws Exception {
+ List<Pair<String, String>> urlsAndRequestBodies = new ArrayList<>(brokerUrls.size());
+ brokerUrls.forEach((url) -> urlsAndRequestBodies.add(Pair.of(url, "")));
+
+ CompletionService<MultiHttpRequestResponse> completionService =
+ new MultiHttpRequest(_executor, _connectionManager).execute(urlsAndRequestBodies, requestHeaders,
+ DELETE_TIMEOUT_MS, "DELETE", HttpDelete::new);
+
+ Map<String, String> responseMap = new HashMap<>();
+ List<String> errMessages = new ArrayList<>();
+
+ for (int i = 0; i < brokerUrls.size(); i++) {
+ try (MultiHttpRequestResponse httpRequestResponse = completionService.take().get()) {
+ URI uri = httpRequestResponse.getURI();
+ int status = httpRequestResponse.getResponse().getCode();
+ String responseString = EntityUtils.toString(httpRequestResponse.getResponse().getEntity());
+
+ if (status == 200) {
+ responseMap.put(getInstanceKey(uri.getHost(), Integer.toString(uri.getPort())), responseString);
+ } else if (status == 404) {
+ // 404 means the response is already deleted - this is acceptable for idempotent cleanup
+ LOGGER.debug("Response already deleted (404) for uri: {}", uri);
+ responseMap.put(getInstanceKey(uri.getHost(), Integer.toString(uri.getPort())),
+ "Already deleted (was 404)");
+ } else {
+ // Other errors are unexpected and should be logged
+ LOGGER.warn("Unexpected status={} from uri='{}', response='{}'", status, uri, responseString);
+ errMessages.add(String.format("Unexpected status=%d from uri='%s'", status, uri));
+ }
+ } catch (Exception e) {
+ LOGGER.error("Failed to execute DELETE op", e);
+ errMessages.add(e.getMessage());
+ }
+ }
+
+ if (!errMessages.isEmpty()) {
+ throw new Exception("Some delete operations failed: " + StringUtils.join(errMessages, ", "));
Review Comment:
Throwing a generic `Exception` loses type information and makes exception handling harder for callers. Consider creating a specific exception type (e.g., `ResponseStoreCleanupException`) or using an existing appropriate exception type.
##########
pinot-controller/src/test/java/org/apache/pinot/controller/cursors/ResponseStoreCleanerTest.java:
##########
@@ -0,0 +1,332 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.controller.cursors;
+
+import com.sun.net.httpserver.HttpExchange;
+import com.sun.net.httpserver.HttpHandler;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.net.URI;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executor;
+import java.util.concurrent.Executors;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager;
+import org.apache.helix.model.InstanceConfig;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.response.broker.CursorResponseNative;
+import org.apache.pinot.controller.ControllerConf;
+import org.apache.pinot.controller.LeadControllerManager;
+import org.apache.pinot.controller.helix.core.PinotHelixResourceManager;
+import org.apache.pinot.controller.utils.FakeHttpServer;
+import org.apache.pinot.spi.metrics.PinotMetricUtils;
+import org.apache.pinot.spi.utils.JsonUtils;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+
+
+public class ResponseStoreCleanerTest {
+ private static final String RESPONSE_STORE_PATH = "/responseStore";
+ private static final long CURRENT_TIME_MS = 1000000L;
+
+ private final Executor _executor = Executors.newFixedThreadPool(4);
+ private final PoolingHttpClientConnectionManager _connectionManager = new PoolingHttpClientConnectionManager();
Review Comment:
The connection manager is created but never closed. Add `_connectionManager.close()` in the `@AfterClass` method to properly release resources.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java:
##########
@@ -170,51 +245,54 @@ private Map<String, List<CursorResponseNative>> getAllQueryResults(Map<String, I
int port = portOverride > 0 ? portOverride : broker.getPort();
brokerUrls.add(String.format(QUERY_RESULT_STORE, protocol, broker.getHost(), port));
}
- LOGGER.debug("Getting running queries via broker urls: {}", brokerUrls);
- Map<String, String> strResponseMap = getResponseMap(requestHeaders, brokerUrls, "GET", HttpGet::new);
- return strResponseMap.entrySet().stream().collect(Collectors.toMap(Map.Entry::getKey, e -> {
- try {
- return JsonUtils.stringToObject(e.getValue(), new TypeReference<>() {
- });
- } catch (IOException ex) {
- throw new RuntimeException(ex);
- }
- }));
- }
+ LOGGER.debug("Getting stored responses via broker urls: {}", brokerUrls);
- private <T extends HttpUriRequestBase> Map<String, String> getResponseMap(Map<String, String> requestHeaders,
- List<String> brokerUrls, String methodName, Function<String, T> httpRequestBaseSupplier)
- throws Exception {
List<Pair<String, String>> urlsAndRequestBodies = new ArrayList<>(brokerUrls.size());
brokerUrls.forEach((url) -> urlsAndRequestBodies.add(Pair.of(url, "")));
CompletionService<MultiHttpRequestResponse> completionService =
new MultiHttpRequest(_executor, _connectionManager).execute(urlsAndRequestBodies, requestHeaders,
- ResponseStoreCleaner.TIMEOUT_MS, methodName, httpRequestBaseSupplier);
- Map<String, String> responseMap = new HashMap<>();
- List<String> errMessages = new ArrayList<>(brokerUrls.size());
+ GET_TIMEOUT_MS, "GET", HttpGet::new);
+
+ Map<String, List<CursorResponseNative>> responseMap = new HashMap<>();
+ List<String> errMessages = new ArrayList<>();
+
for (int i = 0; i < brokerUrls.size(); i++) {
try (MultiHttpRequestResponse httpRequestResponse = completionService.take().get()) {
- // The completion order is different from brokerUrls, thus use uri in the response.
URI uri = httpRequestResponse.getURI();
int status = httpRequestResponse.getResponse().getCode();
String responseString = EntityUtils.toString(httpRequestResponse.getResponse().getEntity());
- // Unexpected server responses are collected and returned as exception.
+
if (status != 200) {
- throw new Exception(
- String.format("Unexpected status=%d and response='%s' from uri='%s'", status, responseString, uri));
+ errMessages.add(String.format("Unexpected status=%d from uri='%s', response='%s'",
+ status, uri, responseString));
+ continue;
+ }
+
+ String brokerKey = getInstanceKey(uri.getHost(), Integer.toString(uri.getPort()));
+ try {
+ List<CursorResponseNative> responses = JsonUtils.stringToObject(responseString, new TypeReference<>() {
+ });
+ responseMap.put(brokerKey, responses);
+ LOGGER.debug("Got {} stored responses from broker: {}", responses.size(), brokerKey);
+ } catch (IOException ex) {
+ LOGGER.error("Failed to parse response from broker: {}", brokerKey, ex);
+ errMessages.add(String.format("Failed to parse response from broker '%s': %s", brokerKey, ex.getMessage()));
}
- responseMap.put((getInstanceKey(uri.getHost(), Integer.toString(uri.getPort()))), responseString);
} catch (Exception e) {
- LOGGER.error("Failed to execute {} op. ", methodName, e);
- // Can't just throw exception from here as there is a need to release the other connections.
- // So just collect the error msg to throw them together after the for-loop.
+ LOGGER.error("Failed to execute GET op", e);
errMessages.add(e.getMessage());
}
}
+
if (!errMessages.isEmpty()) {
- throw new Exception("Unexpected responses from brokers: " + StringUtils.join(errMessages, ","));
+ LOGGER.warn("Some brokers failed to respond: {}", errMessages);
+ // Only throw if ALL brokers failed - allow partial success
+ if (responseMap.isEmpty()) {
+ throw new Exception("All brokers failed to respond: " + StringUtils.join(errMessages, ", "));
Review Comment:
Similar to the delete operations, throwing a generic `Exception` loses type information. Consider using a more specific exception type for better error handling.
```suggestion
throw new IOException("All brokers failed to respond: " + StringUtils.join(errMessages, ", "));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix ResponseStoreCleaner bugs causing unbounded response store growth and cleanup failures [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #17622:
URL: https://github.com/apache/pinot/pull/17622#issuecomment-3855532243
That's a good suggestion but I think that will be a larger refactor than this targeted bugfix, and I've created a separate issue for it as a future enhancement - https://github.com/apache/pinot/issues/17643.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix ResponseStoreCleaner bugs causing unbounded response store growth and cleanup failures [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17622:
URL: https://github.com/apache/pinot/pull/17622#issuecomment-3843418102
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/17622?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.49%. Comparing base ([`8de3f2f`](https://app.codecov.io/gh/apache/pinot/commit/8de3f2fb6529a196903ff78adcaac5be65b942e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2689a29`](https://app.codecov.io/gh/apache/pinot/commit/2689a2971aa34edec054adb98ce8460aedf1ed78?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (8de3f2f) and HEAD (2689a29). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (8de3f2f) | HEAD (2689a29) |
>|------|------|------|
>|java-21|5|1|
>|unittests1|2|1|
>|unittests|4|1|
>|temurin|10|1|
>|java-11|5|0|
>|unittests2|2|0|
>|integration|6|0|
>|integration2|2|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17622 +/- ##
============================================
- Coverage 63.18% 55.49% -7.69%
+ Complexity 1479 702 -777
============================================
Files 3173 2474 -699
Lines 189917 140070 -49847
Branches 29064 22333 -6731
============================================
- Hits 119994 77736 -42258
+ Misses 60596 55763 -4833
+ Partials 9327 6571 -2756
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.49% <ø> (-7.64%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.49% <ø> (-7.69%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.49% <ø> (-7.69%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.49% <ø> (-0.04%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/17622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/17622?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org