You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/02 23:49:48 UTC

[GitHub] [spark] HyukjinKwon commented on pull request #34786: [SPARK-37508][SQL][DOCS][FOLLOW-UP] Update expression desc of `CONTAINS()` string function

HyukjinKwon commented on pull request #34786:
URL: https://github.com/apache/spark/pull/34786#issuecomment-985093877


   > make it more clear
   
   Please clarify that you're documenting when to return false.
   
   > Existed UT
   
   Existing unittests don't cover this. You can simply say you verified it after documentation build or SQL command such s `DESCRIBE FUNCTION EXTENDED contains`.
   
   > Make function description more clear
   
   Please describe why. e.g.) to guide users about when false is retured.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org