You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Karl Heinz Marbaise (JIRA)" <ji...@apache.org> on 2017/05/06 18:20:04 UTC

[jira] [Closed] (MNG-6025) Add a ProjectArtifactsCache similar to PluginArtifactsCache

     [ https://issues.apache.org/jira/browse/MNG-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Heinz Marbaise closed MNG-6025.
------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 3.5.1-candidate)
                       (was: needing-scrub-3.4.0-fallout)
                   3.5.1

Done with [be223808939d75152d7157db33d45f230114555e|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=be223808939d75152d7157db33d45f230114555e]

> Add a ProjectArtifactsCache similar to PluginArtifactsCache
> -----------------------------------------------------------
>
>                 Key: MNG-6025
>                 URL: https://issues.apache.org/jira/browse/MNG-6025
>             Project: Maven
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.3.9
>            Reporter: Anton Tanasenko
>            Assignee: Jason van Zyl
>            Priority: Minor
>             Fix For: 3.5.1
>
>
> Every mojo execution, if it specifies dependency resolution other than 'none', will cause a resolution to be performed.
> There is a guard in MojoExecutor's DependencyContext which guards against performing this resolution multiple times by looking at the changes to dependencyArtifacts list.
> However, during a build in an incremental/interactive environment, like eclipse m2e or maven console, those mojos might be executed at an arbitrary time and will not benefit from that DependencyContext check.
> I propose having a ProjectArtifactsCache (very similar to PluginArtifactsCache) that will cache artifact set as returned by LifecycleDependencyResolver#getDependencies().
> While it does not improve cli builds, incremental/interactive builds will receive a huge performance boost between pom changes.
> I've been able to get build of a project with a lot of dependencies (jenkins plugin) and a number of (fully incremental) mojo executions from 7 seconds to around 1.5 on a single java file change in eclipse m2e after introducing this cache.
> I will provide a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)