You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/30 22:39:26 UTC
[GitHub] [pulsar-client-go] pgier opened a new pull request, #800: ci: add makefile
pgier opened a new pull request, #800:
URL: https://github.com/apache/pulsar-client-go/pull/800
- add a Makefile with basic build, test, clean, etc.
- simplify the Dockerfile by moving some scripts and conf files to directories
- update README
### Motivation
Add a Makefile to make it easier to remember the commands for building and testing the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] michaeljmarshall merged pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915378145
##########
Dockerfile:
##########
@@ -17,21 +17,19 @@
# under the License.
#
-ARG GO_VERSION=golang:1.15
-FROM apachepulsar/pulsar:2.8.2 as pulsar
-FROM $GO_VERSION as go
+ARG PULSAR_IMAGE=apachepulsar/pulsar:latest
+ARG GOLANG_IMAGE=golang:latest
Review Comment:
Added a comment about setting the version during build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r916067709
##########
README.md:
##########
@@ -24,9 +24,9 @@
[](https://github.com/apache/pulsar-client-go/blob/master/LICENSE)
# Apache Pulsar Go Client Library
-A Go client library for the [Apache Pulsar](https://pulsar.incubator.apache.org/) project.
+A Go client library for [Apache Pulsar](https://pulsar.incubator.apache.org/).
Review Comment:
Yep, it's updated now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] zzzming commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
zzzming commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915347112
##########
Dockerfile:
##########
@@ -17,21 +17,19 @@
# under the License.
#
-ARG GO_VERSION=golang:1.15
-FROM apachepulsar/pulsar:2.8.2 as pulsar
-FROM $GO_VERSION as go
+ARG PULSAR_IMAGE=apachepulsar/pulsar:latest
+ARG GOLANG_IMAGE=golang:latest
+
+FROM $PULSAR_IMAGE as pulsar
+FROM $GOLANG_IMAGE
RUN apt-get update && apt-get install -y openjdk-11-jre-headless ca-certificates
COPY --from=pulsar /pulsar /pulsar
-### Add test scripts
+### Add pulsar config
COPY integration-tests/certs /pulsar/certs
COPY integration-tests/tokens /pulsar/tokens
-COPY integration-tests/standalone.conf /pulsar/conf
-COPY integration-tests/client.conf /pulsar/conf
-COPY integration-tests/.htpasswd /pulsar/conf
+COPY integration-tests/conf /pulsar/conf
+
Review Comment:
Explicitly copying the file is easier to debug a problem if someone delete any file and not add any files that are not necessary.
##########
Dockerfile:
##########
@@ -17,21 +17,19 @@
# under the License.
#
-ARG GO_VERSION=golang:1.15
-FROM apachepulsar/pulsar:2.8.2 as pulsar
-FROM $GO_VERSION as go
+ARG PULSAR_IMAGE=apachepulsar/pulsar:latest
+ARG GOLANG_IMAGE=golang:latest
Review Comment:
It'd better to keep the fixed version of base image. It is hard to trouble shoot problems if the latest points to a new version. That forces other PRs to deal with version problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] Shoothzj commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915372470
##########
README.md:
##########
@@ -24,9 +24,9 @@
[](https://github.com/apache/pulsar-client-go/blob/master/LICENSE)
# Apache Pulsar Go Client Library
-A Go client library for the [Apache Pulsar](https://pulsar.incubator.apache.org/) project.
+A Go client library for [Apache Pulsar](https://pulsar.incubator.apache.org/).
Review Comment:
the link should be updated, too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915371157
##########
Dockerfile:
##########
@@ -17,21 +17,19 @@
# under the License.
#
-ARG GO_VERSION=golang:1.15
-FROM apachepulsar/pulsar:2.8.2 as pulsar
-FROM $GO_VERSION as go
+ARG PULSAR_IMAGE=apachepulsar/pulsar:latest
+ARG GOLANG_IMAGE=golang:latest
Review Comment:
The version is fixed in the Makefile, so CI builds would always use the version set there. I set these to default to latest so that they don't become out of date. I can add a comment to the Dockerfile saying that these versions should be set via the Makefile or CLI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915378038
##########
Dockerfile:
##########
@@ -17,21 +17,19 @@
# under the License.
#
-ARG GO_VERSION=golang:1.15
-FROM apachepulsar/pulsar:2.8.2 as pulsar
-FROM $GO_VERSION as go
+ARG PULSAR_IMAGE=apachepulsar/pulsar:latest
+ARG GOLANG_IMAGE=golang:latest
+
+FROM $PULSAR_IMAGE as pulsar
+FROM $GOLANG_IMAGE
RUN apt-get update && apt-get install -y openjdk-11-jre-headless ca-certificates
COPY --from=pulsar /pulsar /pulsar
-### Add test scripts
+### Add pulsar config
COPY integration-tests/certs /pulsar/certs
COPY integration-tests/tokens /pulsar/tokens
-COPY integration-tests/standalone.conf /pulsar/conf
-COPY integration-tests/client.conf /pulsar/conf
-COPY integration-tests/.htpasswd /pulsar/conf
+COPY integration-tests/conf /pulsar/conf
+
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915378883
##########
README.md:
##########
@@ -24,9 +24,9 @@
[](https://github.com/apache/pulsar-client-go/blob/master/LICENSE)
# Apache Pulsar Go Client Library
-A Go client library for the [Apache Pulsar](https://pulsar.incubator.apache.org/) project.
+A Go client library for [Apache Pulsar](https://pulsar.incubator.apache.org/).
Review Comment:
Good catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] zzzming commented on a diff in pull request #800: ci: add makefile
Posted by GitBox <gi...@apache.org>.
zzzming commented on code in PR #800:
URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915990874
##########
README.md:
##########
@@ -24,9 +24,9 @@
[](https://github.com/apache/pulsar-client-go/blob/master/LICENSE)
# Apache Pulsar Go Client Library
-A Go client library for the [Apache Pulsar](https://pulsar.incubator.apache.org/) project.
+A Go client library for [Apache Pulsar](https://pulsar.incubator.apache.org/).
Review Comment:
The link is an old incubator link. It should be updated without incubator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org