You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@mitre.org> on 2013/06/27 23:23:27 UTC
Review Request 12139: Adding in tests for rave_api and rave_state_manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12139/
-----------------------------------------------------------
Review request for rave.
Repository: rave
Description
-------
Adding in tests for rave_api and rave_state_manager
Diffs
-----
/branches/require/rave-portal-resources/pom.xml 1497549
/branches/require/rave-portal-resources/src/test/javascript/core/rave_api.spec 1497549
/branches/require/rave-portal-resources/src/test/javascript/core/rave_state_manager.spec 1497549
/branches/require/rave-portal-resources/src/test/javascript/rave_api_spec.js 1497549
/branches/require/rave-portal-resources/src/test/requireConfig.js 1497549
/branches/require/rave-portal-resources/src/test/testTemplate.htmltemplate 1497549
Diff: https://reviews.apache.org/r/12139/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request 12139: Adding in tests for rave_api and rave_state_manager
Posted by Erin Noe-Payne <er...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12139/#review22491
-----------------------------------------------------------
Ship it!
In state manager we can test getters / setters together in a single test method.
We may want to change the spec naming convention so that the test files can have .js for convenience when editing in the ide.
- Erin Noe-Payne
On June 27, 2013, 9:23 p.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12139/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 9:23 p.m.)
>
>
> Review request for rave.
>
>
> Repository: rave
>
>
> Description
> -------
>
> Adding in tests for rave_api and rave_state_manager
>
>
> Diffs
> -----
>
> /branches/require/rave-portal-resources/pom.xml 1497549
> /branches/require/rave-portal-resources/src/test/javascript/core/rave_api.spec 1497549
> /branches/require/rave-portal-resources/src/test/javascript/core/rave_state_manager.spec 1497549
> /branches/require/rave-portal-resources/src/test/javascript/rave_api_spec.js 1497549
> /branches/require/rave-portal-resources/src/test/requireConfig.js 1497549
> /branches/require/rave-portal-resources/src/test/testTemplate.htmltemplate 1497549
>
> Diff: https://reviews.apache.org/r/12139/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>