You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by ottobackwards <gi...@git.apache.org> on 2017/09/15 11:59:06 UTC
[GitHub] metron pull request #761: METRON-1143 [FEATURE BRANCH] [NO-MERGE until PR#74...
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/761
METRON-1143 [FEATURE BRANCH] [NO-MERGE until PR#747] Management UI Support for Parser Extensions
## Contributor Comments
This PR introduces Management UI support for parser extensions. It is based on the currently unmerged [PR 747](https://github.com/apache/metron/pull/747), and will be rebased when that hits the feature branch.
I believe that with this, we have mvp functionality with the parser extensions, as the creation of kafka topics, the availability of storm slots etc are existing issues beyond the extensions in general.
The UI support adds a new page for listing the installed extensions and the parsers they contain, and allows the installation and removal of those extensions.
<img width="1403" alt="screen shot 2017-09-15 at 07 10 42" src="https://user-images.githubusercontent.com/1111551/30480791-93c0d3b6-99e9-11e7-9606-10e486183a4e.png">
<img width="1146" alt="screen shot 2017-09-15 at 07 10 55" src="https://user-images.githubusercontent.com/1111551/30480795-9b3b35dc-99e9-11e7-8b68-7fa5cdb7165e.png">
<img width="1408" alt="screen shot 2017-09-15 at 07 11 30" src="https://user-images.githubusercontent.com/1111551/30480803-a55748bc-99e9-11e7-90d1-1aba66f205c7.png">
<img width="1409" alt="screen shot 2017-09-15 at 07 11 44" src="https://user-images.githubusercontent.com/1111551/30480805-a8771842-99e9-11e7-81e7-44307dbd6337.png">
<img width="324" alt="screen shot 2017-09-15 at 07 11 58" src="https://user-images.githubusercontent.com/1111551/30480808-aae287c4-99e9-11e7-9fa5-9793744f01a3.png">
<img width="1397" alt="screen shot 2017-09-15 at 07 12 31" src="https://user-images.githubusercontent.com/1111551/30480811-af8ddd82-99e9-11e7-9036-41efd7b0b9e1.png">
## Testing
- Build a parser extension per: https://github.com/apache/metron/blob/feature/METRON-1136-extensions-parsers/metron-maven-archetypes/metron-parser-extension-archetype/README.md
round trip:
- run in full dev
- go to the extension page
- click the add button
- find the archive.tar.gz of your extension from the assembly/target
- install
- select the extension in the list with the checkbox
- actions -> delete
After install, the parser(s) installed with the extension will be available in the sensors list
After install, you can create a new sensor config based on that parser
You should be able to start your parser by using the same rest ( swagger instructions )
such as documented in the readme above.
## TODO:
I don't have tests for all the components
I have not looked at the end to end stuff and may need help there
The install dialog needs css styling, and I need help with that.
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [na] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron ext-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #761
----
commit ebe343a3d783f223809bd9a81f19ea209a65fb13
Author: Otto Fowler <ot...@gmail.com>
Date: 2017-09-11T12:47:17Z
BundleSystem is now and interface, with the builder set out as it's own class
BundleSystemTypes is introduced to allow specification of the type when building
OnDemandBundleSystem and DefaultBundleSystem created, OnDemand creating the BundleSystem on first use
for lazy init and holder pattern.
This allows using BundleSystem (OnDemand) as a bean in spring
commit 1b79329c5428b353c895e8d1e58a5731e12a84bd
Author: Otto Fowler <ot...@gmail.com>
Date: 2017-09-14T11:43:13Z
fix merge
debug log statements
commit f802759b474a3569e183eb629d256a351a36247e
Author: Otto Fowler <ot...@gmail.com>
Date: 2017-09-07T01:41:10Z
Configuration Management UI for Parser Extensions
* install
* uninstall
* list
TODO: end to end? styling for install panel, tests for all components
----
---
[GitHub] metron issue #761: METRON-1143 [FEATURE BRANCH] [NO-MERGE until PR#747] Mana...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/761
closing, will be landed down the line
---
[GitHub] metron pull request #761: METRON-1143 [FEATURE BRANCH] [NO-MERGE until PR#74...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/761
---