You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/24 10:10:27 UTC
[GitHub] [airflow-client-python] msumit opened a new pull request #14: Update links in PyPi
msumit opened a new pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] kaxil commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619647923
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
I feel we should have separate docs for the python-client so that we can also have an Updating guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] kaxil commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619647859
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
oh wait was the version 1.0.0 in the released candidate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] msumit commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
msumit commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619660041
##########
File path: setup.py
##########
@@ -23,12 +23,10 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
-VERSION = "1.0.0"
+VERSION = "2.0.0"
Review comment:
@kaxil I think using ver 2.0.0 isn't correct, as we've already released 2.0.0, so the code in the master is post 2.0.0 cut. We might name it 2.0.0.dev or whatever it is in airflow master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] kaxil commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619655622
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
Exactly my point :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] kaxil commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619647859
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
oh wait was the version 1.0.0 in the released candidate?
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
I feel we should have separate docs for the python-client so that we can also have an Updating guide
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
coz https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html has the version of the API and it might be confusing
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
Exactly my point :)
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
Yup just checked
##########
File path: setup.py
##########
@@ -23,12 +23,10 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
-VERSION = "1.0.0"
+VERSION = "2.0.0"
Review comment:
Yeah: let's change it to `2.1.0.dev`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] kaxil commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619656161
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
Yup just checked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] msumit merged pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
msumit merged pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] kaxil commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619648320
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
coz https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html has the version of the API and it might be confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] kaxil commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619660556
##########
File path: setup.py
##########
@@ -23,12 +23,10 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
-VERSION = "1.0.0"
+VERSION = "2.0.0"
Review comment:
Yeah: let's change it to `2.1.0.dev`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] msumit commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
msumit commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619660041
##########
File path: setup.py
##########
@@ -23,12 +23,10 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
-VERSION = "1.0.0"
+VERSION = "2.0.0"
Review comment:
@kaxil I think using ver 2.0.0 isn't correct, as we've already released 2.0.0, so the code in the master is post 2.0.0 cut. We might name it 2.0.0.dev or whatever it is in airflow master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] potiuk commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619644050
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
```suggestion
VERSION = "2.0.0"
```
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
```suggestion
Documentation=https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] potiuk commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619654304
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
But yeah, I agree at some point in time we might want to have "Updating guide" for the client. So I agree eventually we should have a section for clients like we have "providers" and "docker-stack" now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] potiuk commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619654034
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
The link is with "stable" and I think it is good as is - API is more of a property of Airflow not the client, so it conceptually belongs to Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] potiuk commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619644050
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
```suggestion
VERSION = "2.0.0"
```
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
```suggestion
Documentation=https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html
```
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
I think @msumit manually updated it (I checked in PyPI and they are ok + I think twine would reject it if the name <> version
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
The link is with "stable" and I think it is good as is - API is more of a property of Airflow not the client, so it conceptually belongs to Airflow.
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
But yeah, I agree at some point in time we might want to have "Updating guide" for the client. So I agree eventually we should have a section for clients like we have "providers" and "docker-stack" now.
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
In this case we should likely have a completely separate "Airflow API" section and have sub-sections for:
```
1) API specs
2) Clients
- Python
- Go ....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] potiuk commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619654504
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = dev@airflow.apache.org
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
In this case we should likely have a completely separate "Airflow API" section and have sub-sections for:
```
1) API specs
2) Clients
- Python
- Go ....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] potiuk commented on a change in pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14#discussion_r619653860
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
I think @msumit manually updated it (I checked in PyPI and they are ok + I think twine would reject it if the name <> version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-python] msumit merged pull request #14: Update links in PyPi
Posted by GitBox <gi...@apache.org>.
msumit merged pull request #14:
URL: https://github.com/apache/airflow-client-python/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org