You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/12/20 16:15:32 UTC
[GitHub] flink pull request #3034: [FLINK-5363] Fire timers when window state is curr...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3034
[FLINK-5363] Fire timers when window state is currently empty
Before this change, when a Trigger sets a timer and that timer fires in
the future at a point when there is currently no data in the window
state, then that timer is being ignored.
This was a problem for some users because they manually set cleanup
timers and they need to be called because the trigger needs to cleanup
some state. (For normal time windows this is not a problem, but for
special cases built on top of GlobalWindows the old behaviour was
leading to problems.)
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink fire-trigger-with-empty-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3034
----
commit b8bfdf05ae9bfb546a223c5f638016a3e18f41bb
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-12-18T17:33:13Z
[FLINK-5363] Fire timers when window state is currently empty
Before this change, when a Trigger sets a timer and that timer fires in
the future at a point when there is currently no data in the window
state, then that timer is being ignored.
This was a problem for some users because they manually set cleanup
timers and they need to be called because the trigger needs to cleanup
some state. (For normal time windows this is not a problem, but for
special cases built on top of GlobalWindows the old behaviour was
leading to problems.)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3034: [FLINK-5363] Fire timers when window state is curr...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3034: [FLINK-5363] Fire timers when window state is currently e...
Posted by cjolif <gi...@git.apache.org>.
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/3034
> It could, but I think we don't want to do this change right now.
we are getting into cases where this feature would be useful. Do you have any insights on why you finally don't want to make this feasible?
---
[GitHub] flink issue #3034: [FLINK-5363] Fire timers when window state is currently e...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3034
R: @klou and @StephanEwen for review, please. (Or anyone who's interested, of course)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3034: [FLINK-5363] Fire timers when window state is currently e...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3034
@aljoscha can the new behavior be demonstrated by a test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3034: [FLINK-5363] Fire timers when window state is currently e...
Posted by cjolif <gi...@git.apache.org>.
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/3034
@aljoscha
We regularly empty the window because we can get lengthy windows with a lot of elements, so it is good get rid of elements we already managed. But then if we have no more elements and the window event time is triggered it does fire the window function.
When we will get some spare cycle we are going to give a try to it as you seem to have fix that according to the JIRA issue?
---
[GitHub] flink issue #3034: [FLINK-5363] Fire timers when window state is currently e...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3034
It could, but I think we don't want to do this change right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3034: [FLINK-5363] Fire timers when window state is currently e...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3034
hi @cjolif what are the cases where you would need this?
---