You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2025/04/22 12:36:48 UTC
[PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
AlenkaF opened a new pull request, #46199:
URL: https://github.com/apache/arrow/pull/46199
### Rationale for this change
`PyExtensionType` has been deprecated in https://github.com/apache/arrow/pull/38608 and can now be removed.
### What changes are included in this PR?
`PyExtensionType` functionality is removed from PyArrow code.
### Are these changes tested?
Existing tests should pass.
### Are there any user-facing changes?
Deprecated classes are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #46199:
URL: https://github.com/apache/arrow/pull/46199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2839696281
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 26170b477a790052086805dfa02646a732c60957.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/41367806721) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2823491086
@pitrou, I have submitted https://github.com/pitrou/pyarrow-hotfix/pull/8 (tested locally with the changes in this PR and with pyarrow 19.0.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2821396008
Can you check if it breaks https://pypi.org/project/pyarrow-hotfix/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2834641180
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2821436142
Yeah, it breaks it:
```python
>>> import pyarrow_hotfix
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/alenkafrim/Envs/pyarrow-dev/lib/python3.12/site-packages/pyarrow_hotfix/__init__.py", line 110, in <module>
install()
File "/Users/alenkafrim/Envs/pyarrow-dev/lib/python3.12/site-packages/pyarrow_hotfix/__init__.py", line 66, in install
pa.unregister_extension_type("arrow.py_extension_type")
File "pyarrow/types.pxi", line 2281, in pyarrow.lib.unregister_extension_type
check_status(UnregisterPyExtensionType(c_type_name))
File "pyarrow/error.pxi", line 92, in pyarrow.lib.check_status
raise convert_status(status)
pyarrow.lib.ArrowKeyError: No type extension with name arrow.py_extension_type found
```
Should I propose an update in the [pyarrow-hotfix repo](https://github.com/pitrou/pyarrow-hotfix) `__init__.py` for PyArrow versions `>= 21.0.0` similar to https://github.com/pitrou/pyarrow-hotfix/blob/main/src/pyarrow_hotfix/__init__.py#L39?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2821838526
@AlenkaF Yes, please do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2830350675
As [pyarrow-hotfix update](https://github.com/pitrou/pyarrow-hotfix/pull/8) has been merged, this PR is ready for review.
cc @raulcd @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46198: [Python] Remove deprecated PyExtensionType [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46199:
URL: https://github.com/apache/arrow/pull/46199#issuecomment-2834651341
Revision: b4b3728ff4967bdcf6766743c298bf96ce9a11d1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2813be5290](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2813be5290)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932759/job/41262849930)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932553/job/41262848489)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/14704933213/job/41262854308)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932386/job/41262846650)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932641/job/41262849897)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932508/job/41262847403)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/14704934654/job/41262862264)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932784/job/41262850086)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/14704935091/job/41262863815)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14704934970/job/41262863450)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/14704935476/job/41262864333)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932968/job/41262852009)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14704933483/job/41262860889)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14704934688/job/41262861406)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/14704934684/job/41262863379)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/14704936080/job/41262865976)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/14704933013/job/41262851515)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932578/job/41262848051)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932913/job/41262852746)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932985/job/41262851647)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14704935705/job/41262865505)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932327/job/41262847177)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932818/job/41262850040)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14704932823/job/41262852135)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14704934768/job/41262862582)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14704934657/job/41262863919)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/14704935478/job/41262865836)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14704934623/job/41262861648)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org