You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 16:35:22 UTC

[GitHub] [arrow-rs] crepererum commented on a change in pull request #258: support full u64 roundtrip through parquet

crepererum commented on a change in pull request #258:
URL: https://github.com/apache/arrow-rs/pull/258#discussion_r626724693



##########
File path: parquet/src/arrow/array_reader.rs
##########
@@ -380,6 +380,18 @@ impl<T: DataType> ArrayReader for PrimitiveArrayReader<T> {
                 }
                 Arc::new(builder.finish()) as ArrayRef
             }
+            ArrowType::UInt64 => match array.data_type() {

Review comment:
       As far as I can see we always cast the array, see default case in line 383 (pre-patch) / 395 (post-patch). So we would always copy, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org