You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/09/06 07:21:30 UTC

[GitHub] [kylin] codecov-io commented on issue #827: #KYLIN-4158, limit not push down to storage scan level if group by is…

codecov-io commented on issue #827: #KYLIN-4158, limit not push down to storage scan level if group by is…
URL: https://github.com/apache/kylin/pull/827#issuecomment-528742896
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/827?src=pr&el=h1) Report
   > Merging [#827](https://codecov.io/gh/apache/kylin/pull/827?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/800d1c59d0e7c2915be320e83d3bd5efb6afc268?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/827/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/827?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #827      +/-   ##
   ============================================
   - Coverage     25.62%   25.61%   -0.01%     
     Complexity     6050     6050              
   ============================================
     Files          1398     1398              
     Lines         83523    83528       +5     
     Branches      11701    11702       +1     
   ============================================
   - Hits          21400    21398       -2     
   - Misses        60070    60078       +8     
   + Partials       2053     2052       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/827?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://codecov.io/gh/apache/kylin/pull/827/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0dUQ3ViZVN0b3JhZ2VRdWVyeUJhc2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/827/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/827/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.61%)` | `7% <0%> (ø)` | |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/827/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/827?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/827?src=pr&el=footer). Last update [800d1c5...b8451df](https://codecov.io/gh/apache/kylin/pull/827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services