You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2012/07/09 14:27:25 UTC
[Bug 53525] New: PROPPATCH delete (svn propdel) errors not returned
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
Priority: P2
Bug ID: 53525
Assignee: bugs@httpd.apache.org
Summary: PROPPATCH delete (svn propdel) errors not returned
Severity: normal
Classification: Unclassified
OS: Linux
Reporter: arwin@collab.net
Hardware: PC
Status: NEW
Version: 2.5-HEAD
Component: mod_dav
Product: Apache httpd-2
Created attachment 29042
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29042&action=edit
Suggested patch to fix this bug.
On failure to execute a PROPPATCH to remove a property, the error is not
returned to the caller.
A comment in the code says:
<code snippet>
1044: /*
1045: ** Delete the property. Ignore errors -- the property is there, or
1046: ** we are deleting it for a second time.
1047: */
1048: /* ### but what about other errors? */
1049: (void) (*propdb->db_hooks->remove)(propdb->db, &name);
</code snippet>
In subversion, property deletions are subject to authorization, and hook script
execution.
In the current state of things, regardless of the outcome of the PROPPATCH, the
client receives a 2xx class response. I suggest the attached patch to fix this.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 53525] PROPPATCH delete (svn propdel) errors not returned
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 53525] PROPPATCH delete (svn propdel) errors not returned
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
Graham Leggett <mi...@sharp.fm> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |WONTFIX
--- Comment #4 from Graham Leggett <mi...@sharp.fm> ---
Vetoed by jorton, citing http://tools.ietf.org/html/rfc4918#section-14.23
This patch is an RFC violation, reverted on trunk.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 53525] PROPPATCH delete (svn propdel) errors not returned
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
--- Comment #1 from Graham Leggett <mi...@sharp.fm> ---
Applied to trunk in r1476627.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 53525] PROPPATCH delete (svn propdel) errors not returned
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
--- Comment #5 from Arwin Arni <ar...@collab.net> ---
The RFC says "Specifying the removal of a property that does not exist is not
an error."
What this patch is trying to solve is the "failure to delete an existing
property".
Can someone please explain how this is an RFC violation?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 53525] PROPPATCH delete (svn propdel) errors not returned
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
Graham Leggett <mi...@sharp.fm> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Graham Leggett <mi...@sharp.fm> ---
Can you verify that the patch works for you?
Proposed for backport to v2.4.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 53525] PROPPATCH delete (svn propdel) errors not returned
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
C. Michael Pilato <cm...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gstein@gmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 53525] PROPPATCH delete (svn propdel) errors not returned
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53525
--- Comment #3 from Graham Leggett <mi...@sharp.fm> ---
Proposed for backport to v2.2.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org