You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2011/03/23 18:59:05 UTC
[jira] [Closed] (THRIFT-1105) OCaml generator does not prefix
methods of included structs with their type
[ https://issues.apache.org/jira/browse/THRIFT-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1105.
---------------------------------
Resolution: Fixed
Assignee: Joel Reymont
I just committed this.
> OCaml generator does not prefix methods of included structs with their type
> ---------------------------------------------------------------------------
>
> Key: THRIFT-1105
> URL: https://issues.apache.org/jira/browse/THRIFT-1105
> Project: Thrift
> Issue Type: Bug
> Components: OCaml - Compiler
> Affects Versions: 0.7
> Environment: Mac OSX 10.6
> Reporter: Joel Reymont
> Assignee: Joel Reymont
> Fix For: 0.7
>
> Attachments: 0001-THRIFT-1105-OCaml-generator-does-not-prefix-methods-.patch
>
>
> --- Doc.thrift
> struct Document {
> 1: string user_name
> 2: string document_name
> }
> typedef Document page_id
> --- Ranking.thrift
> include "Doc.thrift"
> struct Request {
> 1: Doc.page_id page
> }
> ---
> thrift -gen ocaml Doc.thrift
> thrift -gen ocaml Ranking.thrift
> ---
> You will see
> #set_page (read_document iprot)
> generated in read_request, instead of the proper
> #set_page (Doc_types.read_document iprot)
> Generated code fails to compile as a result.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira