You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/14 07:01:00 UTC
[GitHub] [incubator-kyuubi] SteNicholas opened a new pull request #1904: [KYUUBI #1903] Add GetTableTypes for trino engine
SteNicholas opened a new pull request #1904:
URL: https://github.com/apache/incubator-kyuubi/pull/1904
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Add GetTableTypes for trino engine.
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #1904: [KYUUBI #1903] Add GetTableTypes for trino engine
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #1904:
URL: https://github.com/apache/incubator-kyuubi/pull/1904#issuecomment-1038722649
@hddong, could you please review this simple pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1904: [KYUUBI #1903] Add GetTableTypes for trino engine
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1904:
URL: https://github.com/apache/incubator-kyuubi/pull/1904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1904: [KYUUBI #1903] Add GetTableTypes for trino engine
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1904:
URL: https://github.com/apache/incubator-kyuubi/pull/1904#issuecomment-1038796170
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on pull request #1904: [KYUUBI #1903] Add GetTableTypes for trino engine
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1904:
URL: https://github.com/apache/incubator-kyuubi/pull/1904#issuecomment-1038730868
@SteNicholas : Thanks, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #1904: [KYUUBI #1903] Add GetTableTypes for trino engine
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #1904:
URL: https://github.com/apache/incubator-kyuubi/pull/1904#issuecomment-1038784663
@hddong, the result of CI is passed. Please help to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas edited a comment on pull request #1904: [KYUUBI #1903] Add GetTableTypes for trino engine
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #1904:
URL: https://github.com/apache/incubator-kyuubi/pull/1904#issuecomment-1038722649
@yaooqinn @hddong, could you please review this simple pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org