You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 08:48:00 UTC

[GitHub] [spark] attilapiros commented on a change in pull request #31935: [SPARK-34789][TEST] Introduce Jetty based construct for integration tests where HTTP server is used

attilapiros commented on a change in pull request #31935:
URL: https://github.com/apache/spark/pull/31935#discussion_r610457742



##########
File path: core/src/main/scala/org/apache/spark/TestUtils.scala
##########
@@ -364,6 +369,22 @@ private[spark] object TestUtils {
     }
   }
 
+  def withHttpServer(resBaseDir: String = ".")(body: URL => Unit): Unit = {

Review comment:
       I think this a very useful structure and we could use it even for testing Spark submits better.
   So I would like to leave this here, if it is OK for you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org