You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/01/02 02:15:48 UTC
Re: Review Request 40529: Added helper function to get stateless
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 一月 2, 2016, 1:15 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3
src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 6, 2016, 12:10 p.m., Klaus Ma wrote:
> > include/mesos/v1/resources.hpp, line 155
> > <https://reviews.apache.org/r/40529/diff/13/?file=1180271#file1180271line155>
> >
> > s/Resource/`Resource`, or s/Resource/resource
All of the comments are using "Resources", so here just follow to make consistent.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/#review113054
-----------------------------------------------------------
On 一月 2, 2016, 1:15 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40529/
> -----------------------------------------------------------
>
> (Updated 一月 2, 2016, 1:15 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to get stateless resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
> include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
> src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3
> src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
> src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764
>
> Diff: https://reviews.apache.org/r/40529/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/#review113054
-----------------------------------------------------------
include/mesos/v1/resources.hpp (line 155)
<https://reviews.apache.org/r/40529/#comment173560>
s/Resource/`Resource`, or s/Resource/resource
include/mesos/v1/resources.hpp (line 156)
<https://reviews.apache.org/r/40529/#comment173561>
I'd like to say: Currently, the resources without persistent volumes are considered to be `stateless`.
include/mesos/v1/resources.hpp (line 243)
<https://reviews.apache.org/r/40529/#comment173562>
ditto
- Klaus Ma
On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40529/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 9:15 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to get stateless resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
> include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
> src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3
> src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
> src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764
>
> Diff: https://reviews.apache.org/r/40529/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 三月 15, 2016, 2:31 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp bb343ad852576a75615a93ef850b413bf77698e0
include/mesos/v1/resources.hpp 719110fbbf39f1755460ac0b32e3893656054a4e
src/common/resources.cpp 1f23dc83f7330c305a836d698f114b7eaf3d7ba1
src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 三月 11, 2016, 9:07 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176
include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e
src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 一月 22, 2016, 3:18 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 一月 8, 2016, 1:35 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Changes
-------
Rebase
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4
src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 一月 7, 2016, 7:57 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4
src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu