You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/10/01 12:43:47 UTC

[PR] chore: camel-jbang - a view bar on every tab with views (Inspect, Errors, Route, Endpoint, HTTP, Metrics, Memory Leak), as the Diagram tab [camel]

davsclaus opened a new pull request, #27203:
URL: https://github.com/apache/camel/pull/27203

   _Claude Code on behalf of davsclaus_
   
   The Diagram tab's level bar (`v ◇ Architecture › ◆ Topology › ◇ Route` with its view settings at the right) is now shared: every tab that has views gets the same bar on its first row.
   
   | Tab | Views | Settings in the bar |
   |---|---|---|
   | Diagram | Architecture › Topology › Route | ai, view, group, utility, metrics, external, detail (as before) |
   | Inspect | Steps (Exchanges) │ Waterfall │ Diagram | description, wrap |
   | Errors | Errors │ Diagram | handled filter, wrap; description in the diagram |
   | Route | Routes │ Diagram | description, top; metrics, external, detail, description in the diagram |
   | Endpoint | Chart │ Detail (the bottom panel) | filter, chart |
   | HTTP | Endpoints │ Probe │ Spec | filter, management |
   | Metrics | Dashboard │ Table │ Prometheus | filter (table) |
   | Memory Leak | Samples │ Dominators (with results) | min-size, mode |
   
   How the bar behaves:
   - The view shown is highlighted. A view that does not apply yet is greyed out: a route view without a route, the error diagram without a selected error that has a message history, Probe/Spec without a selected endpoint (with a spec).
   - Levels are separated by `›`, peer views by `│`.
   - A click on a view goes there. A click on a setting presses its key, as a click on a footer hint does.
   - The settings shown in the bar are left out of the footer. They are still listed with the footer actions for MCP agents: `MonitorTab.renderViewToggles` defaults to the bar's settings.
   - Tabs with only on/off settings (Log, Overview, Spans) keep them in the footer, so they do not lose a row.
   
   ### How
   - `SubViewBar` replaces `DiagramLevelBar`.
   - A tab describes its bar with `MonitorTab.subViewBar()`. `CamelMonitor` draws it on the first row of the tab's content and routes clicks on it.
   - The Diagram tab's `Level` enum moved into `DiagramTab`.
   
   About "a click on a (c) sub tab does not work": a click on the Diagram levels worked when tested through a pty with SGR mouse events, but the settings on the right of the bar were not clickable. Both are clickable now, on every tab with a bar.
   
   ### Tests
   - `SubViewBarTest` replaces `DiagramLevelBarTest`: views, settings, a click on a view or a setting, `›` vs `│`.
   - The footer tests of the Endpoint, Errors and Metrics tabs check the bar.
   - The full camel-jbang-plugin-tui module passes. Checked live on each tab, including clicks on a view and a setting.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: camel-jbang - a view bar on every tab with views (Inspect, Errors, Route, Endpoint, HTTP, Metrics, Memory Leak), as the Diagram tab [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27203:
URL: https://github.com/apache/camel/pull/27203#issuecomment-5931733398

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: camel-jbang - a view bar on every tab with views (Inspect, Errors, Route, Endpoint, HTTP, Metrics, Memory Leak), as the Diagram tab [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #27203:
URL: https://github.com/apache/camel/pull/27203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: camel-jbang - a view bar on every tab with views (Inspect, Errors, Route, Endpoint, HTTP, Metrics, Memory Leak), as the Diagram tab [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27203:
URL: https://github.com/apache/camel/pull/27203#issuecomment-5931973060

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `dsl/camel-jbang/camel-jbang-plugin-tui`
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison — Scalpel: 2 of 697 tested, 1 compile-only — current: 2 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **2 affected modules** (current approach: 2).
   
   **Skip-tests mode would test 2 modules** (1 direct + 1 downstream), **skip tests for 1** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (2)</summary>
   
   - `camel-jbang-plugin-tui` ← dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/AbstractTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/CamelMonitor.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/DiagramLevelBar.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/DiagramTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/ErrorsTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HistoryTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HttpTab.java, dsl/camel-jbang/camel-jbang-plugin-tui
 /src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MemoryLeakTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MetricsTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MonitorTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/RoutesTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/SubViewBar.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/DiagramLevelBarTest.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTabRenderTest.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/ErrorsTabRenderTest.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/cor
 e/commands/tui/MetricsTabRenderTest.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/SubViewBarTest.java
   - `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
   
   </details>
   
   <details><summary>Modules with tests skipped (1)</summary>
   
   - `camel-launcher`
   
   </details>
   
   > :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   <details><summary>All tested modules (3 modules, 1m 18s total)</summary>
   
   **Total reactor time:** 1m 18s
   
   | Module | Duration | Status |
   | --- | --- | --- |
   | Camel :: JBang :: Plugin :: TUI | 40.8s | SUCCESS |
   | Camel :: Launcher | 36.2s | SUCCESS |
   | Camel :: Launcher :: Container | 0.8s | SUCCESS |
   
   **Top 20 slowest modules:**
   - `Camel :: JBang :: Plugin :: TUI` (40.8s)
   - `Camel :: Launcher` (36.2s)
   - `Camel :: Launcher :: Container` (0.8s)
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/36863717864)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org