You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/24 19:17:24 UTC

[GitHub] [geode] jinmeiliao commented on a change in pull request #7258: GEODE-9704: Ready for events was happening before it should

jinmeiliao commented on a change in pull request #7258:
URL: https://github.com/apache/geode/pull/7258#discussion_r791075268



##########
File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java
##########
@@ -802,10 +803,13 @@ private QueueConnectionImpl createNewPrimary(Set<ServerLocation> excludedServers
       excludedServers.addAll(servers);
     }
 
+    return primary;

Review comment:
       My only concern is that after this change, `createNewPrimary()` method doesn't send `readyForEvent` to the server anymore. This method has two usages: `recoveryPrimary` and `initializeConnections`, `readyForEvent` will be sent by the first usage. As long as we know for sure it has no impact on the 2nd usage. Then this fix should be fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org