You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "progval (via GitHub)" <gi...@apache.org> on 2023/06/30 12:20:41 UTC

[GitHub] [orc] progval opened a new pull request, #1558: Mark DataBuffer::size() and DataBuffer::capacity() as const

progval opened a new pull request, #1558:
URL: https://github.com/apache/orc/pull/1558

   ### What changes were proposed in this pull request?
   
   These two accessors do not mutate the state, so they can be tagged as `const` to indicate this into callers.
   
   
   ### Why are the changes needed?
   
   I am writing a Rust binding, and the methods not being `const` give me extra constraints.
   
   
   ### How was this patch tested?
   
   `make test` passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun closed pull request #1558: ORC-1459: Mark `DataBuffer::size()` and `DataBuffer::capacity()` as `const`

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1558: ORC-1459: Mark `DataBuffer::size()` and `DataBuffer::capacity()` as `const`
URL: https://github.com/apache/orc/pull/1558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1558: ORC-1459: Mark `DataBuffer::size()` and `DataBuffer::capacity()` as `const`

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1558:
URL: https://github.com/apache/orc/pull/1558#issuecomment-1615343518

   Merged to `main` branch for Apache ORC 2.0.0.
   Welcome to the Apache ORC community, @progval .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1558: ORC-1459: Mark `DataBuffer::size()` and `DataBuffer::capacity()` as `const`

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1558:
URL: https://github.com/apache/orc/pull/1558#issuecomment-1615325695

   I filed an official Apache ORC JIRA for this PR. Could you enroll to Apache JIRA system and let us know?
   - https://issues.apache.org/jira/browse/ORC-1459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] progval commented on pull request #1558: ORC-1459: Mark `DataBuffer::size()` and `DataBuffer::capacity()` as `const`

Posted by "progval (via GitHub)" <gi...@apache.org>.
progval commented on PR #1558:
URL: https://github.com/apache/orc/pull/1558#issuecomment-1615764218

   Thanks! My Jira profile is: https://issues.apache.org/jira/secure/ViewProfile.jspa?name=progval


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org