[jira] [Commented] (GEODE-3438) Collection added to itself

["Anthony Baker (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445057#comment-16445057 ] 

Anthony Baker commented on GEODE-3438:
--------------------------------------

[~lifove] sorry for the delayed response.  Thanks for this report!  I agree that we need to look into this issue.

> Collection added to itself
> --------------------------
>
>                 Key: GEODE-3438
>                 URL: https://issues.apache.org/jira/browse/GEODE-3438
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: JC
>            Priority: Major
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: master
> Path: geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DurableCqNamesResult.java
> {code:java}
> ...
>  27   private List<String> cqNames = new ArrayList<String>();
> ...
>  33   public DurableCqNamesResult(final String memberNameOrId, List<String> cqNames) {
>  34     super(memberNameOrId);
>  35     cqNames.addAll(cqNames);
>  36   }
> {code}
> In Line 35, should `cqNames.addAll' be `this.cqNames.addAll'? This might not be an issue, but I wanted to report just in case.
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)