You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/28 13:15:06 UTC

[jira] [Commented] (COUCHDB-2677) Wrong Expires header weekday

    [ https://issues.apache.org/jira/browse/COUCHDB-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516824#comment-14516824 ] 

ASF GitHub Bot commented on COUCHDB-2677:
-----------------------------------------

GitHub user samueltardieu opened a pull request:

    https://github.com/apache/couchdb/pull/317

    Week of day for past expiration date 1990-01-01 is Monday

    Fixes COUCHDB-2677

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/samueltardieu/couchdb wrong-weekday-in-expires-header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #317
    
----
commit 6e0202cc757f8f8c19250b312d4ac2e25d642a88
Author: Samuel Tardieu <sa...@rfc1149.net>
Date:   2015-04-28T11:12:42Z

    Week of day for past expiration date 1990-01-01 is Monday
    
    Fixes COUCHDB-2677

----


> Wrong Expires header weekday
> ----------------------------
>
>                 Key: COUCHDB-2677
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2677
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: HTTP Interface
>    Affects Versions: 1.6.1
>            Reporter: Samuel Tardieu
>
> The Expires header returned by /_uuids pretends that Jan. 1st 1990 was a Friday, while it was a Monday (http://www.timeanddate.com/calendar/?year=1990).
> {code}
> % curl -v http://localhost:5984/_uuids
> *   Trying ::1...
> * Connected to localhost (::1) port 5984 (#0)
> > GET /_uuids HTTP/1.1
> > Host: localhost:5984
> > User-Agent: curl/7.42.0
> > Accept: */*
> > 
> < HTTP/1.1 200 OK
> < Server: CouchDB/1.6.1 (Erlang OTP/17)
> < Pragma: no-cache
> < Expires: Fri, 01 Jan 1990 00:00:00 GMT
> < ETag: "6LTRS9X19427AV07PBMVAX1T5"
> < Date: Tue, 28 Apr 2015 10:57:30 GMT
> < Content-Type: text/plain; charset=utf-8
> < Content-Length: 47
> < Cache-Control: must-revalidate, no-cache
> < 
> {"uuids":["a1e0504a69677e3fe4c0d7b65500059b"]}
> {code}
> The HTTP parser in Akka detects this and warns about it:
> {code}
> [WARN] [04/28/2015 12:57:59.649] [canape-test-akka.actor.default-dispatcher-2] [ActorSystem(canape-test)] Illegal response header: Illegal 'expires' header: Illegal weekday in date 1990-01-01T00:00:00: is 'Fri' but should be 'Mon'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)