Re: svn commit: r702656 - in /cxf/trunk/rt/transports/jms/src: main/java/org/apache/cxf/transport/jms/ test/java/org/apache/cxf/transport/jms/

[Eric Johnson <er...@iona.com>]

I like the use of "you" also. It  avoids needlessly convoluted syntax
and it makes the messages a little more personal.

That said consistency is king.

How about:

Configure a <jms:conduit name=\"{0}\"> and set the
jndiConnectionFactoryName.

The jmsConfig property is required.

Benson's suggestion for the second error message is perfect.


> 
On Tue, 2008-10-07 at 19:28 -0400, Benson Margulies wrote:
> Well, I've always liked technical writing that uses 'you' to avoid the
> passive. Since this is a config error, it seems to me to have an audience
> that can handle a you. But that's just my opinion.
> 
> On Tue, Oct 7, 2008 at 7:25 PM, Glen Mazza <gl...@gmail.com> wrote:
> 
> >
> > Christian, usage of "you" is somewhat uncommon in error messages, wouldn't
> > you say?  Although I think it's more permissable for the first two messages
> > below, because you're asking a question, but normally the latter two should
> > avoid "you".
> >
> > Glen
> >
> > cschneider-2 wrote:
> > >
> > >  DISPATCH_FAILURE_MSG = Dispatch of incoming JMS request failed
> > > +INSUFFICIENT_CONFIGURATION_CONDUIT = Insufficient configuration for
> > > Conduit. Did you configure a <jms:conduit name=\"{0}\"> and set the
> > > jndiConnectionFactoryName ?
> >
> > Be sure to configure a ... and set the jndiConnectionFactoryName.
> >
> > > +INSUFFICIENT_CONFIGURATION_DESTINATION = Insufficient configuration for
> > > Destination. Did you configure a <jms:destination name=\"{0}\"> and set
> > > the jndiConnectionFactoryName ?
> >
> > Be sure to configure a ... and set the jndiConnectionFactoryName.
> >
> > > +JMSCONFIGFEATURE_ONLY_JMS = You can only use JMSConfigFeature with the
> > > jms transport
> >
> > JMSConfigFeature can only be used with jms transport.
> >
> > > +JMSCONFIG_REQUIRED = You have to set the property jmsConfig
> >
> > Property jmsConfig has to be set -or- was not set -or- must be set
> >
> > --
> > View this message in context:
> > http://www.nabble.com/Re%3A-svn-commit%3A-r702656---in--cxf-trunk-rt-transports-jms-src%3A-main-java-org-apache-cxf-transport-jms--test-java-org-apache-cxf-transport-jms--tp19869512p19869512.html
> > Sent from the cxf-dev mailing list archive at Nabble.com.
> >
> >