[GitHub] [airflow] eejbyfeldt commented on issue #13808: Task incorrectly marked as orphaned when using 2 schedulers

[GitBox <gi...@apache.org>]

eejbyfeldt commented on issue #13808:
URL: https://github.com/apache/airflow/issues/13808#issuecomment-801152433


   > @ephraimbuddy @dimberman @eejbyfeldt @kaxil
   > 
   > We have created a PR for this which seems to resolve it for us:
   > #14795
   > 
   > Would it be possible to review this? I'm not sure if it will resolve it for this particular issue, but certainly when a single scheduler is used, and that pod is terminated over and over again, without this fix the tasks are not correctly adopted after the first restart.
   
   We have also seen these problems with this issue running a single scheduler since reporting this. So it is possible that we wrongly assumed it was related to running two schedulers since that made it more prominent for us. 
   
   I have had a look at the PR and I agree that the usage of `external_executor_id` inside `try_adopt_task_instances` while updating `queued_by_job_id` outside seems problematic. But I am not familiar enough with the code to say what is the correct solution.
   
   Thanks for helping to make some progress towards solving this issue. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org