You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/24 06:59:51 UTC

[GitHub] [apisix] YuanYingdong opened a new pull request #6437: fix: format code in redirect.lua

YuanYingdong opened a new pull request #6437:
URL: https://github.com/apache/apisix/pull/6437


   ### What this PR does / why we need it:
   I found there is some code format error in `redirect.lua` and fixed it.
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the PR manners:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
   6. Use "request review" to notify the reviewer once you have resolved the review
   7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
   -->
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on pull request #6437: fix: format code in redirect.lua

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6437:
URL: https://github.com/apache/apisix/pull/6437#issuecomment-1050466117


   @tzssangglass 
   We can't accept any PR which just corrects a code style problem. I don't want to be trapped in a code-style debate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander closed pull request #6437: fix: format code in redirect.lua

Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #6437:
URL: https://github.com/apache/apisix/pull/6437


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tzssangglass commented on pull request #6437: fix: format code in redirect.lua

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6437:
URL: https://github.com/apache/apisix/pull/6437#issuecomment-1050571057


   got


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org