You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/25 19:27:08 UTC
[GitHub] [tvm] kparzysz-quic opened a new pull request #9117: [Codegen] Swap out analyzer when outlining
kparzysz-quic opened a new pull request #9117:
URL: https://github.com/apache/tvm/pull/9117
Problem: the `analyzer_` in `CodeGenLLVM` and derived classes can generate invalid code for outlined functions.
Consider code like this:
```
let x = y in
// attr compute_scope
blah = x
```
Then it gets outlined in codegen_cpu (for example):
```
let x = y in
call foo(x)
foo(x) {
blah = x
}
```
Now, if `analyzer_->Simplify` was run on the body of `foo`, it would produce:
```
foo(x) {
blah = y
}
```
Because the `analyzer_` knows that `x` is same as `y` (because of the `Let` statemement), but doesn't know that `y` is no longer
available in the outlined function `foo`.
See
https://discuss.tvm.apache.org/t/compute-scope-issue-with-analyzer-invalid-simplification/11111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #9117: [Codegen] Swap out analyzer when outlining
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #9117:
URL: https://github.com/apache/tvm/pull/9117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #9117: [Codegen] Swap out analyzer when outlining
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #9117:
URL: https://github.com/apache/tvm/pull/9117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org