You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/03/22 21:00:59 UTC

[jira] Created: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

PropertyDescriptor constructors throws incorrect (or no) exception
------------------------------------------------------------------

         Key: HARMONY-237
         URL: http://issues.apache.org/jira/browse/HARMONY-237
     Project: Harmony
        Type: Bug
  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Minor


Passing all null arguments to these constructors gives incorrect behaviour.

j.beans.PropertyDescriptor(j.l.String,j.l.Class):
  RI throws j.beans.IntrospectionException but
  Harmony throws j.l.NullPointerException

j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
  RI throws j.beans.IntrospectionException but
  Harmony throws j.l.NullPointerException

j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
  RI throws j.beans.IntrospectionException but
  Harmony doesn't throw an exception

Will attach a patch.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-237?page=all ]

Mikhail Loenko reassigned HARMONY-237:
--------------------------------------

    Assign To: Mikhail Loenko

> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-237?page=all ]
     
Mikhail Loenko resolved HARMONY-237:
------------------------------------

    Resolution: Fixed

fixed in revision 395794
Mark, please verify that it fully resolves the problem

> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-237?page=all ]

Mark Hindess updated HARMONY-237:
---------------------------------

    Attachment: 02.propertydescriptor.empty.propery.name.diff

This patch, 02.*.diff,  must be applied after the first one and fixes the related case where the three parameter constructor is called with a propertyName that is the empty string.


> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-237?page=comments#action_12375497 ] 

Mark Hindess commented on HARMONY-237:
--------------------------------------

Looks like the fix in the 02 patch is missing?
-Mark.


> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-237?page=comments#action_12376701 ] 

Mark Hindess commented on HARMONY-237:
--------------------------------------

Just to confirm the tests were there.  So this can be closed.  Thanks Mikhail.

> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-237?page=all ]
     
Mikhail Loenko closed HARMONY-237:
----------------------------------


verified by Mark

> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-237?page=all ]

Mark Hindess updated HARMONY-237:
---------------------------------

    Attachment: propertydescriptor.npe.diff

This patch fixes the exception behaviour to match the RI (1.5.0_06) and adds some tests.


> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-237?page=comments#action_12375501 ] 

Mikhail Loenko commented on HARMONY-237:
----------------------------------------

right it was applied to 2 out of 3 methods. please check again in 395801

> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-237?page=comments#action_12375504 ] 

Mark Hindess commented on HARMONY-237:
--------------------------------------

This fixes the behaviour but it looks like the tests from the first patch for the three argument case and from the second patch are still missing.


> PropertyDescriptor constructors throws incorrect (or no) exception
> ------------------------------------------------------------------
>
>          Key: HARMONY-237
>          URL: http://issues.apache.org/jira/browse/HARMONY-237
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: 02.propertydescriptor.empty.propery.name.diff, propertydescriptor.npe.diff
>
> Passing all null arguments to these constructors gives incorrect behaviour.
> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
>   RI throws j.beans.IntrospectionException but
>   Harmony throws j.l.NullPointerException
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Method):
>   RI throws j.beans.IntrospectionException but
>   Harmony doesn't throw an exception
> Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira