[GitHub] [rocketmq-connect] zhangjidi2016 commented on a diff in pull request #126: [ISSUE #124]Some sink /source metric statistics are incorrect

[GitBox <gi...@apache.org>]

zhangjidi2016 commented on code in PR #126:
URL: https://github.com/apache/rocketmq-connect/pull/126#discussion_r874577071


##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerSinkTask.java:
##########
@@ -421,7 +421,7 @@ private void pullMessageFromQueues() throws InterruptedException {
             if (null != pullResult && pullResult.getPullStatus().equals(PullStatus.FOUND)) {
                 this.incPullTPS(entry.getKey().getTopic(), pullResult.getMsgFoundList().size());
                 messages = pullResult.getMsgFoundList();
-                connectStatsManager.incSinkRecordReadTotalNums();
+                connectStatsManager.incSinkRecordReadTotalNums(messages.size());

Review Comment:
   add SourceRecordPollTotalTimes represents the source poll times, SinkRecordReadTotalTimes represents the sink read times



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org