You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sk0x50 (via GitHub)" <gi...@apache.org> on 2024/02/21 18:05:54 UTC
[PR] IGNITE-21460 Add an ability to specify ignored failure types [ignite-3]
sk0x50 opened a new pull request, #3248:
URL: https://github.com/apache/ignite-3/pull/3248
https://issues.apache.org/jira/browse/IGNITE-21460
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21460 Add an ability to specify ignored failure types [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #3248:
URL: https://github.com/apache/ignite-3/pull/3248#discussion_r1499129316
##########
modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java:
##########
@@ -49,4 +53,21 @@ void testFailureProcessing() {
failureProcessor.stop();
}
}
+
+ @Test
+ void testIgnoredFailureTypes() {
+ FailureHandler handler = new NoOpFailureHandler();
+
+ FailureProcessor failureProcessor = new FailureProcessor("node_name", handler);
+
+ assertThat(failureProcessor.start(), willSucceedFast());
+
+ try {
+ assertThat(failureProcessor.process(new FailureContext(SYSTEM_WORKER_BLOCKED, null)), is(false));
+
+ assertThat(failureProcessor.process(new FailureContext(SYSTEM_CRITICAL_OPERATION_TIMEOUT, null)), is(false));
+ } finally {
+ failureProcessor.stop();
+ }
Review Comment:
Honestly, it is not obvious from the javadoc that it is allowed to call `stop` on non started component. Anyway. I fixed it in the way you proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21460 Add an ability to specify ignored failure types [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #3248:
URL: https://github.com/apache/ignite-3/pull/3248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21460 Add an ability to specify ignored failure types [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #3248:
URL: https://github.com/apache/ignite-3/pull/3248#discussion_r1499127213
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/handlers/AbstractFailureHandler.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.failure.handlers;
+
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_CRITICAL_OPERATION_TIMEOUT;
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_WORKER_BLOCKED;
+
+import java.util.Collections;
+import java.util.EnumSet;
+import java.util.Set;
+import org.apache.ignite.internal.failure.FailureContext;
+import org.apache.ignite.internal.failure.FailureType;
+import org.apache.ignite.internal.tostring.IgniteToStringInclude;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Abstract superclass for {@link FailureHandler} implementations. Maintains a set of ignored failure types.
+ */
+public abstract class AbstractFailureHandler implements FailureHandler {
+ /** List of ignored failure types. */
+ @IgniteToStringInclude
+ private Set<FailureType> ignoredFailureTypes =
+ Collections.unmodifiableSet(EnumSet.of(SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT));
+
+ /**
+ * Sets failure types that must be ignored by failure handler.
+ *
+ * @param failureTypes Set of failure type that must be ignored.
+ * @see FailureType
+ */
+ public void ignoredFailureTypes(Set<FailureType> failureTypes) {
+ ignoredFailureTypes = Collections.unmodifiableSet(failureTypes);
+ }
+
+ /**
+ * Returns unmodifiable set of ignored failure types.
+ */
+ public Set<FailureType> ignoredFailureTypes() {
+ return ignoredFailureTypes;
+ }
+
+ @Override
+ public boolean onFailure(String nodeName, FailureContext failureCtx) {
+ return !ignoredFailureTypes.contains(failureCtx.type()) && handle(nodeName, failureCtx);
+ }
+
+ /**
+ * Actual failure handling. This method is not called for ignored failure types.
+ *
+ * @see #ignoredFailureTypes(Set)
+ * @see FailureHandler#onFailure(String, FailureContext)
+ */
+ protected abstract boolean handle(String nodeName, FailureContext failureCtx);
+
+ @Override public String toString() {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21460 Add an ability to specify ignored failure types [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #3248:
URL: https://github.com/apache/ignite-3/pull/3248#discussion_r1499014756
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureProcessor.java:
##########
@@ -115,7 +119,11 @@ private synchronized boolean process(FailureContext failureCtx, FailureHandler h
return false;
}
- LOG.error(FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
+ if (failureTypeIgnored(failureCtx, handler)) {
+ LOG.warn(IGNORED_FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
Review Comment:
```suggestion
LOG.warn(IGNORED_FAILURE_LOG_MSG + "[hnd={}, failureCtx={}]", failureCtx.error(), handler, failureCtx);
```
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/handlers/AbstractFailureHandler.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.failure.handlers;
+
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_CRITICAL_OPERATION_TIMEOUT;
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_WORKER_BLOCKED;
+
+import java.util.Collections;
+import java.util.EnumSet;
+import java.util.Set;
+import org.apache.ignite.internal.failure.FailureContext;
+import org.apache.ignite.internal.failure.FailureType;
+import org.apache.ignite.internal.tostring.IgniteToStringInclude;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Abstract superclass for {@link FailureHandler} implementations. Maintains a set of ignored failure types.
+ */
+public abstract class AbstractFailureHandler implements FailureHandler {
+ /** List of ignored failure types. */
+ @IgniteToStringInclude
+ private Set<FailureType> ignoredFailureTypes =
Review Comment:
```suggestion
private volatile Set<FailureType> ignoredFailureTypes =
```
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureProcessor.java:
##########
@@ -115,7 +119,11 @@ private synchronized boolean process(FailureContext failureCtx, FailureHandler h
return false;
}
- LOG.error(FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
+ if (failureTypeIgnored(failureCtx, handler)) {
+ LOG.warn(IGNORED_FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
+ } else {
+ LOG.error(FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
Review Comment:
```suggestion
LOG.error(FAILURE_LOG_MSG + "[hnd={}, failureCtx={}]", failureCtx.error(), handler, failureCtx);
```
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/handlers/AbstractFailureHandler.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.failure.handlers;
+
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_CRITICAL_OPERATION_TIMEOUT;
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_WORKER_BLOCKED;
+
+import java.util.Collections;
+import java.util.EnumSet;
+import java.util.Set;
+import org.apache.ignite.internal.failure.FailureContext;
+import org.apache.ignite.internal.failure.FailureType;
+import org.apache.ignite.internal.tostring.IgniteToStringInclude;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Abstract superclass for {@link FailureHandler} implementations. Maintains a set of ignored failure types.
+ */
+public abstract class AbstractFailureHandler implements FailureHandler {
+ /** List of ignored failure types. */
+ @IgniteToStringInclude
+ private Set<FailureType> ignoredFailureTypes =
+ Collections.unmodifiableSet(EnumSet.of(SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT));
+
+ /**
+ * Sets failure types that must be ignored by failure handler.
+ *
+ * @param failureTypes Set of failure type that must be ignored.
+ * @see FailureType
+ */
+ public void ignoredFailureTypes(Set<FailureType> failureTypes) {
+ ignoredFailureTypes = Collections.unmodifiableSet(failureTypes);
+ }
+
+ /**
+ * Returns unmodifiable set of ignored failure types.
+ */
+ public Set<FailureType> ignoredFailureTypes() {
+ return ignoredFailureTypes;
+ }
+
+ @Override
+ public boolean onFailure(String nodeName, FailureContext failureCtx) {
+ return !ignoredFailureTypes.contains(failureCtx.type()) && handle(nodeName, failureCtx);
+ }
+
+ /**
+ * Actual failure handling. This method is not called for ignored failure types.
+ *
+ * @see #ignoredFailureTypes(Set)
+ * @see FailureHandler#onFailure(String, FailureContext)
+ */
+ protected abstract boolean handle(String nodeName, FailureContext failureCtx);
+
+ @Override public String toString() {
Review Comment:
```suggestion
@Override
public String toString() {
```
##########
modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java:
##########
@@ -49,4 +53,21 @@ void testFailureProcessing() {
failureProcessor.stop();
}
}
+
+ @Test
+ void testIgnoredFailureTypes() {
+ FailureHandler handler = new NoOpFailureHandler();
+
+ FailureProcessor failureProcessor = new FailureProcessor("node_name", handler);
+
+ assertThat(failureProcessor.start(), willSucceedFast());
+
+ try {
+ assertThat(failureProcessor.process(new FailureContext(SYSTEM_WORKER_BLOCKED, null)), is(false));
+
+ assertThat(failureProcessor.process(new FailureContext(SYSTEM_CRITICAL_OPERATION_TIMEOUT, null)), is(false));
+ } finally {
+ failureProcessor.stop();
+ }
Review Comment:
```suggestion
try {
assertThat(failureProcessor.start(), willSucceedFast());
assertThat(failureProcessor.process(new FailureContext(SYSTEM_WORKER_BLOCKED, null)), is(false));
assertThat(failureProcessor.process(new FailureContext(SYSTEM_CRITICAL_OPERATION_TIMEOUT, null)), is(false));
} finally {
failureProcessor.stop();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21460 Add an ability to specify ignored failure types [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #3248:
URL: https://github.com/apache/ignite-3/pull/3248#discussion_r1499126789
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureProcessor.java:
##########
@@ -115,7 +119,11 @@ private synchronized boolean process(FailureContext failureCtx, FailureHandler h
return false;
}
- LOG.error(FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
+ if (failureTypeIgnored(failureCtx, handler)) {
+ LOG.warn(IGNORED_FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
+ } else {
+ LOG.error(FAILURE_LOG_MSG + "[hnd=" + handler + ", failureCtx=" + failureCtx + ']', failureCtx.error());
Review Comment:
Changed to string templates.
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/handlers/AbstractFailureHandler.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.failure.handlers;
+
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_CRITICAL_OPERATION_TIMEOUT;
+import static org.apache.ignite.internal.failure.FailureType.SYSTEM_WORKER_BLOCKED;
+
+import java.util.Collections;
+import java.util.EnumSet;
+import java.util.Set;
+import org.apache.ignite.internal.failure.FailureContext;
+import org.apache.ignite.internal.failure.FailureType;
+import org.apache.ignite.internal.tostring.IgniteToStringInclude;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Abstract superclass for {@link FailureHandler} implementations. Maintains a set of ignored failure types.
+ */
+public abstract class AbstractFailureHandler implements FailureHandler {
+ /** List of ignored failure types. */
+ @IgniteToStringInclude
+ private Set<FailureType> ignoredFailureTypes =
Review Comment:
Thanks. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org