[GitHub] [calcite] rubenada commented on a change in pull request #2255: [CALCITE-4393] ExceptionInInitializerError due to NPE in SqlCallBinding caused by circular dependency

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #2255:
URL: https://github.com/apache/calcite/pull/2255#discussion_r521992807



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCallBinding.java
##########
@@ -145,10 +144,11 @@ public SqlCall getCall() {
       }
       final SqlOperandCountRange range = checker.getOperandCountRange();
       final List<SqlNode> list = Lists.newArrayList(operandList);
+      final SqlCall defaultCall = createDefaultCall();
       while (list.size() < range.getMax()
           && checker.isOptional(list.size())
           && checker.isFixedParameters()) {
-        list.add(DEFAULT_CALL);
+        list.add(defaultCall);

Review comment:
       Thanks, I was not aware that most case indeed did not require the default call. Changed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org