You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwebbeans.apache.org by st...@apache.org on 2012/07/28 13:49:07 UTC
svn commit: r1366652 - in
/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans:
event/ObserverMethodImpl.java util/WebBeansUtil.java
xml/WebBeansErrorHandler.java
Author: struberg
Date: Sat Jul 28 11:49:07 2012
New Revision: 1366652
URL: http://svn.apache.org/viewvc?rev=1366652&view=rev
Log:
OWB-687 remove FINEST loggings in often used parts.
Even doing a isLogEnabled check can be pretty expensive if called
millions of times...
Modified:
openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/ObserverMethodImpl.java
openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java
openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/xml/WebBeansErrorHandler.java
Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/ObserverMethodImpl.java
URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/ObserverMethodImpl.java?rev=1366652&r1=1366651&r2=1366652&view=diff
==============================================================================
--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/ObserverMethodImpl.java (original)
+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/ObserverMethodImpl.java Sat Jul 28 11:49:07 2012
@@ -191,8 +191,6 @@ public class ObserverMethodImpl<T> imple
@SuppressWarnings("unchecked")
public void notify(T event)
{
- logger.log(Level.FINEST, "Notifying with event payload : [{0}]", event);
-
AbstractOwbBean<Object> component = (AbstractOwbBean<Object>) bean;
if (!bean.isEnabled())
{
Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java
URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java?rev=1366652&r1=1366651&r2=1366652&view=diff
==============================================================================
--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java (original)
+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java Sat Jul 28 11:49:07 2012
@@ -39,8 +39,6 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
-import java.util.logging.Level;
-import java.util.logging.Logger;
import javax.annotation.PostConstruct;
@@ -174,8 +172,6 @@ import static org.apache.webbeans.util.I
@SuppressWarnings("unchecked")
public final class WebBeansUtil
{
- private static final Logger logger = WebBeansLoggerFacade.getLogger(WebBeansUtil.class);
-
/**
* Enforcing that interceptor callbacks should not be
* able to throw checked exceptions is configurable
@@ -1577,8 +1573,6 @@ public final class WebBeansUtil
ProducerMethodBean pLeft;
ProducerMethodBean pRight;
- logger.fine("configure Specialized producer beans has started.");
-
// collect all producer method beans
Set<Bean<?>> beans = webBeansContext.getBeanManagerImpl().getBeans();
List<ProducerMethodBean> producerBeans = new ArrayList<ProducerMethodBean>();
@@ -3014,13 +3008,6 @@ public final class WebBeansUtil
{
WebBeansDecoratorConfig.configureDecoratorClass(delegate);
}
- else
- {
- if (logger.isLoggable(Level.FINEST))
- {
- logger.log(Level.FINEST, "Unable to configure decorator with class : [{0}]", annotatedType.getJavaClass());
- }
- }
}
}
@@ -3042,13 +3029,6 @@ public final class WebBeansUtil
webBeansContext.getWebBeansInterceptorConfig().configureInterceptorClass(delegate,
annotationManager.getInterceptorBindingMetaAnnotations(anns));
}
- else
- {
- if (logger.isLoggable(Level.FINEST))
- {
- logger.log(Level.FINEST, "Unable to configure interceptor with class : [{0}]", annotatedType.getJavaClass());
- }
- }
}
}
Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/xml/WebBeansErrorHandler.java
URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/xml/WebBeansErrorHandler.java?rev=1366652&r1=1366651&r2=1366652&view=diff
==============================================================================
--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/xml/WebBeansErrorHandler.java (original)
+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/xml/WebBeansErrorHandler.java Sat Jul 28 11:49:07 2012
@@ -54,7 +54,7 @@ public class WebBeansErrorHandler implem
public void warning(SAXParseException exception) throws SAXException
{
- logger.log(Level.FINE, exception.getMessage(), exception.getCause());
+ logger.log(Level.WARNING, exception.getMessage(), exception.getCause());
}
}