You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "codetyri0n (via GitHub)" <gi...@apache.org> on 2025/10/21 14:09:50 UTC

[PR] Docs: Update SQL example for current_time() and current_date(). [datafusion]

codetyri0n opened a new pull request, #18200:
URL: https://github.com/apache/datafusion/pull/18200

   ## Which issue does this PR close?
   - Closes #18199 
   ## What changes are included in this PR?
   - Added a SQL example in scalar functions md to set execution time zone (optional) for current_time() and current_date().
   ## Are these changes tested?
   ## Are there any user-facing changes?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Docs: Update SQL example for current_time() and current_date(). [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #18200:
URL: https://github.com/apache/datafusion/pull/18200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Docs: Update SQL example for current_time() and current_date(). [datafusion]

Posted by "codetyri0n (via GitHub)" <gi...@apache.org>.
codetyri0n commented on PR #18200:
URL: https://github.com/apache/datafusion/pull/18200#issuecomment-3426959338

   @alamb could you please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Docs: Update SQL example for current_time() and current_date(). [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #18200:
URL: https://github.com/apache/datafusion/pull/18200#issuecomment-3427143060

   I believe these should be modified in the source files instead of this doc as it gets autogenerated, see:
   
   https://github.com/apache/datafusion/blob/b5b7f9b356a5363a71ee1d293df199c9e33206cd/datafusion/functions/src/datetime/current_date.rs#L32-L40
   
   You could add it via a `sql_example` block like here for example:
   
   https://github.com/apache/datafusion/blob/b5b7f9b356a5363a71ee1d293df199c9e33206cd/datafusion/functions-nested/src/range.rs#L63-L77
   
   Then run `./dev/update_function_docs.sh` to generate that doc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Docs: Update SQL example for current_time() and current_date(). [datafusion]

Posted by "codetyri0n (via GitHub)" <gi...@apache.org>.
codetyri0n commented on PR #18200:
URL: https://github.com/apache/datafusion/pull/18200#issuecomment-3427493900

   thanks, ill modify this accordingly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org