[GitHub] [ozone] bshashikant commented on a change in pull request #2167: HDDS-5122. SCM Reinitialization can end up leaking Ratis Segmented RaftLogWorker threads

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #2167:
URL: https://github.com/apache/ozone/pull/2167#discussion_r617276647



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -871,6 +874,7 @@ public static boolean scmBootstrap(OzoneConfiguration conf)
               getScmAddress(scmhaNodeDetails, conf), false);
         }
         scmStorageConfig.setPrimaryScmNodeId(scmInfo.getScmId());
+        scmStorageConfig.setSCMHAFlag(true);

Review comment:
       BootStrap will fail if HA is not enabled right upfront. It won't execute this code at all.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org