You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/10/06 14:52:05 UTC
[GitHub] [carbondata] ShreelekhyaG opened a new pull request #3969: [WIP] document update
ShreelekhyaG opened a new pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969
### Why is this PR needed?
Few document changes in dml, presto-guide.
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-705548840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501500082
##########
File path: docs/dml-of-carbondata.md
##########
@@ -454,6 +461,10 @@ CarbonData DML statements are documented here,which includes:
Review comment:
Can specify without providing expression, it will delete all records from table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501492611
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just supports local mode.
* If run on cluster mode, please upload all input files to distributed file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through tablestatus file.
Review comment:
since this content is already present in Segment Management. no need to add it
##########
File path: docs/dml-of-carbondata.md
##########
@@ -303,6 +304,7 @@ CarbonData DML statements are documented here,which includes:
* The data type of source and destination table columns should be same
* INSERT INTO command does not support partial success if bad records are found, it will fail.
* Data cannot be loaded or updated in source table while insert from source table to target table is in progress.
+ * Each insert creates new segment folder and manages the folder through tablestatus file.
Review comment:
same comment as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r502405706
##########
File path: docs/dml-of-carbondata.md
##########
@@ -447,13 +452,17 @@ CarbonData DML statements are documented here,which includes:
### DELETE
- This command allows us to delete records from CarbonData table.
+ This command allows us to delete records from CarbonData table. Without providing expression, it will delete all the records from table.
Review comment:
this can be added after syntax, as a note
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501492611
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just supports local mode.
* If run on cluster mode, please upload all input files to distributed file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through tablestatus file.
Review comment:
since this content is already present in Segment Management. no need to add it. If needed can update the first line in Segment Management
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501494239
##########
File path: docs/dml-of-carbondata.md
##########
@@ -402,6 +404,11 @@ CarbonData DML statements are documented here,which includes:
## UPDATE AND DELETE
+ Since the data in CarbonData files is immutable, the updates and delete are done via maintaining two files namely:
Review comment:
Can update the line based on filesystem. Like, ` Since the data stored in file system like HDFS is immutable,..`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-705551895
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2590/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
ShreelekhyaG commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501635531
##########
File path: docs/dml-of-carbondata.md
##########
@@ -454,6 +461,10 @@ CarbonData DML statements are documented here,which includes:
Review comment:
Done
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just supports local mode.
* If run on cluster mode, please upload all input files to distributed file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through tablestatus file.
Review comment:
ok. removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-705548840
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4340/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-706997746
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4373/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-706982841
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2623/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [WIP] document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-704404206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] document update
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-704782229
better to change the PR title to the details that this PR does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
ShreelekhyaG commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r503063938
##########
File path: docs/dml-of-carbondata.md
##########
@@ -402,6 +402,11 @@ CarbonData DML statements are documented here,which includes:
## UPDATE AND DELETE
+ Since the data stored in file system like HDFS is immutable, the update and delete in carbondata are done via maintaining two files namely:
Review comment:
Done
##########
File path: docs/dml-of-carbondata.md
##########
@@ -447,13 +452,17 @@ CarbonData DML statements are documented here,which includes:
### DELETE
- This command allows us to delete records from CarbonData table.
+ This command allows us to delete records from CarbonData table. Without providing expression, it will delete all the records from table.
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501492611
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just supports local mode.
* If run on cluster mode, please upload all input files to distributed file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through tablestatus file.
Review comment:
since this content is already present in Segment Management. no need to add it
##########
File path: docs/dml-of-carbondata.md
##########
@@ -303,6 +304,7 @@ CarbonData DML statements are documented here,which includes:
* The data type of source and destination table columns should be same
* INSERT INTO command does not support partial success if bad records are found, it will fail.
* Data cannot be loaded or updated in source table while insert from source table to target table is in progress.
+ * Each insert creates new segment folder and manages the folder through tablestatus file.
Review comment:
same comment as above
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just supports local mode.
* If run on cluster mode, please upload all input files to distributed file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through tablestatus file.
Review comment:
since this content is already present in Segment Management. no need to add it. If needed can update the first line in Segment Management
##########
File path: docs/dml-of-carbondata.md
##########
@@ -402,6 +404,11 @@ CarbonData DML statements are documented here,which includes:
## UPDATE AND DELETE
+ Since the data in CarbonData files is immutable, the updates and delete are done via maintaining two files namely:
Review comment:
Can update the line based on filesystem. Like, ` Since the data stored in file system like HDFS is immutable,..`
##########
File path: docs/dml-of-carbondata.md
##########
@@ -454,6 +461,10 @@ CarbonData DML statements are documented here,which includes:
Review comment:
Can specify without providing expression, it will delete all records from table
##########
File path: docs/dml-of-carbondata.md
##########
@@ -447,13 +452,17 @@ CarbonData DML statements are documented here,which includes:
### DELETE
- This command allows us to delete records from CarbonData table.
+ This command allows us to delete records from CarbonData table. Without providing expression, it will delete all the records from table.
Review comment:
this can be added after syntax, as a note
##########
File path: docs/dml-of-carbondata.md
##########
@@ -402,6 +402,11 @@ CarbonData DML statements are documented here,which includes:
## UPDATE AND DELETE
+ Since the data stored in file system like HDFS is immutable, the update and delete in carbondata are done via maintaining two files namely:
Review comment:
```suggestion
Since the data stored in a file system like HDFS is immutable, the update and delete in carbondata are done via maintaining two files namely:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-704873036
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4323/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
ShreelekhyaG commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501635872
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just supports local mode.
* If run on cluster mode, please upload all input files to distributed file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through tablestatus file.
Review comment:
ok. removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-707514990
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#issuecomment-704870859
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2573/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update
Posted by GitBox <gi...@apache.org>.
ShreelekhyaG commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501635531
##########
File path: docs/dml-of-carbondata.md
##########
@@ -454,6 +461,10 @@ CarbonData DML statements are documented here,which includes:
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org